Follow-up from #2021817-51: Make widgets / formatters work on EntityNG Field value objects.

+++ b/core/lib/Drupal/Core/Entity/Field/FieldItemBase.php
@@ -130,6 +130,7 @@ public function __unset($name) {
     $this->set($name, NULL);
+    unset($this->values[$name]);

This seems to be necessary, as otherwise there are bot fails, see #2014163-43: Bot checks for #2021817. So it looks like we've a problem in set().

CommentFileSizeAuthor
#1 remove-unset-2050201-1.patch439 bytesBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Status: Active » Needs review
FileSize
439 bytes

This means that this should then result in fails?

Status: Needs review » Needs work

The last submitted patch, remove-unset-2050201-1.patch, failed testing.

yched’s picture

;-)

yched’s picture

Issue summary: View changes

fix context

fago’s picture

Status: Needs work » Needs review

1: remove-unset-2050201-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: remove-unset-2050201-1.patch, failed testing.

fago’s picture

Issue summary: View changes
Status: Needs work » Closed (duplicate)