Replace all module_implements() deprecated function calls. [#2045919]

Comment	File	Size	Author
#20	2045919-20-replace-module_implements-calls.patch	39.49 KB	paravibe

#18	2045919-18-replace-module_implements-calls.patch	40.16 KB	paravibe

#16	2045919-16-replace-module_implements-calls.patch	40.28 KB	paravibe

#9	2045919-9-replace-module_implements-calls.patch	41.04 KB	paravibe

#8	2045919-8-replace-module_implements-calls.patch	31.43 KB	paravibe

#4	2045919-4-replace-module_implements-calls.patch	31.44 KB	paravibe

#2	2045919-2-replace-module_implements-calls.patch	31.49 KB	paravibe

Comment #1

benjy CreditAttribution: benjy commented 19 July 2013 at 15:31

Issue tags:

+Novice

Tagging

Log in or register to post comments

Comment #2

paravibe CreditAttribution: paravibe commented 19 July 2013 at 21:43

Assigned:	Unassigned	» paravibe
Status:	Active	» Needs review

File	Size
2045919-2-replace-module_implements-calls.patch	31.49 KB

Done.
Please review and commit.

Log in or register to post comments

Comment #3

benjy CreditAttribution: benjy commented 20 July 2013 at 03:00

Status:

Needs review

» Needs work

There is no need for \Drupal to be absolute. We only do that in documentation.

+++ b/core/includes/bootstrap.incundefined
@@ -1579,7 +1579,7 @@ function watchdog($type, $message, array $variables = NULL, $severity = WATCHDOG
-    foreach (module_implements('watchdog') as $module) {
+    foreach (\Drupal::moduleHandler()->getImplementations('watchdog') as $module) {
       $function = $module . '_watchdog';
       $function($log_entry);
     }

Log in or register to post comments

Comment #4

paravibe CreditAttribution: paravibe commented 20 July 2013 at 06:05

Status:

Needs work

» Needs review

File	Size
2045919-4-replace-module_implements-calls.patch	31.44 KB

OK, thanks benjy.
Left it only for these two files:
core/lib/Drupal/Core/Config/Entity/ConfigStorageController.php
core/lib/Drupal/Core/Entity/DatabaseStorageController.php

Log in or register to post comments

Comment #5

20 July 2013 at 07:11

Status:

Needs review

» Needs work

The last submitted patch, 2045919-4-replace-module_implements-calls.patch, failed testing.

Log in or register to post comments

Comment #6

paravibe CreditAttribution: paravibe commented 20 July 2013 at 08:32

I continue to work on this.

Log in or register to post comments

Comment #7

benjy CreditAttribution: benjy commented 20 July 2013 at 08:52

drupalarv, seems I mislead you a bit on the absolute paths vs relative. They have to be absolute in files with a namespace (which I didn't realise). Which is what caused your test failures.

Here's the relevant link to the docs so you can see for yourself :) https://drupal.org/node/1353118

Log in or register to post comments

Comment #8

paravibe CreditAttribution: paravibe commented 20 July 2013 at 09:40

Status:

Needs work

» Needs review

File	Size
2045919-8-replace-module_implements-calls.patch	31.43 KB

Thanks benjy!
This patch should be good.

Log in or register to post comments

Comment #9

paravibe CreditAttribution: paravibe commented 23 July 2013 at 06:57

File	Size
2045919-9-replace-module_implements-calls.patch	41.04 KB

New patch.
Replace reference in comments and some other files.

Log in or register to post comments

Comment #10

23 July 2013 at 07:00

Status:	Needs review	» Needs work
Issue tags:	-Novice

The last submitted patch, 2045919-9-replace-module_implements-calls.patch, failed testing.

Log in or register to post comments

Comment #11

paravibe CreditAttribution: paravibe commented 23 July 2013 at 07:21

Status:

Needs work

» Needs review

#9: 2045919-9-replace-module_implements-calls.patch queued for re-testing.

Log in or register to post comments

Comment #12

23 July 2013 at 07:29

Status:

Needs review

» Needs work

The last submitted patch, 2045919-9-replace-module_implements-calls.patch, failed testing.

Log in or register to post comments

Comment #13

paravibe CreditAttribution: paravibe commented 23 July 2013 at 10:39

Status:

Needs work

» Needs review

#9: 2045919-9-replace-module_implements-calls.patch queued for re-testing.

Log in or register to post comments

Comment #14

23 July 2013 at 10:42

Status:

Needs review

» Needs work

The last submitted patch, 2045919-9-replace-module_implements-calls.patch, failed testing.

Log in or register to post comments

Comment #16

paravibe CreditAttribution: paravibe commented 23 July 2013 at 18:45

Status:	Needs work	» Needs review
Issue tags:		+Novice

File	Size
2045919-16-replace-module_implements-calls.patch	40.28 KB

A new one. With last core changes.

Log in or register to post comments

Comment #17

23 July 2013 at 19:12

Status:

Needs review

» Needs work

The last submitted patch, 2045919-16-replace-module_implements-calls.patch, failed testing.

Log in or register to post comments

Comment #18

paravibe CreditAttribution: paravibe commented 23 July 2013 at 19:52

Status:

Needs work

» Needs review

File	Size
2045919-18-replace-module_implements-calls.patch	40.16 KB

Just forget to write absolute \Drupal path in some files, sorry.

Log in or register to post comments

Comment #19

benjy CreditAttribution: benjy commented 25 July 2013 at 00:49

Status:

Needs review

» Needs work

This patch no longer applies. If we can get a re-roll we can try get this in ASAP.

Log in or register to post comments

Comment #20

paravibe CreditAttribution: paravibe commented 25 July 2013 at 06:07

Status:

Needs work

» Needs review

File	Size
2045919-20-replace-module_implements-calls.patch	39.49 KB

New one. Will be good if we could apply it ASAP.

Log in or register to post comments

Comment #21

benjy CreditAttribution: benjy commented 25 July 2013 at 12:50

Status:

Needs review

» Reviewed & tested by the community

OK Let's try get this in :)

Log in or register to post comments

Comment #22

catch

he/him

English

CreditAttribution: catch commented 27 July 2013 at 14:31

Status:

Reviewed & tested by the community

» Fixed

Committed/pushed to 8.x, thanks!

Log in or register to post comments

Comment #23

10 August 2013 at 14:31

Automatically closed -- issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #24

ianthomas_uk

he/him

English

Brighton, UK

CreditAttribution: ianthomas_uk commented 26 January 2014 at 01:18

Issue summary:	View changes
Status:	Closed (fixed)	» Active

5 files were hidden/shown/deleted

File	Size
2045919-8-replace-module_implements-calls.patch	31.43 KB

2045919-9-replace-module_implements-calls.patch	41.04 KB

2045919-16-replace-module_implements-calls.patch	40.28 KB

2045919-18-replace-module_implements-calls.patch	40.16 KB

2045919-20-replace-module_implements-calls.patch	39.49 KB

The watchdog function in bootstrap.inc still calls function_exists('module_implements'). This needs to be removed or updated (possibly to class_exists('\Drupal')?)

Log in or register to post comments

Comment #25

ianthomas_uk

he/him

English

Brighton, UK

CreditAttribution: ianthomas_uk commented 28 January 2014 at 14:41

See #325169-81: Move error/exception handler higher up in the bootstrap process for why this function_exists is there.

We should be able to just remove it, but it will need manual testing to confirm there isn't another function that watchdog is dependent on (possibly t).