Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.@frankbaele, thanks for creating this followup.
When working on #1892006: Include a print styling for Seven.. The testbot kept failing on the upgrade path test for the color module.
The patch in 4# changed the style.css stylesheet settings from 'screen' to 'all', what made it pass the check on color.module line 67 and crash on the foreach on line 72 when running the upgrade path tests.
The reason why it crashed is that it is expecting an array and a string was given, this string is passed on by the upgrade part test as test content.
This bug doesn't happen on bartik because bartik doesn't use the all media tag.
This bug doesn't happen on stark because there are no upgrade path tests for stark.
So do we need an upgrade path test for color and seven, since color doesn't have an integration with seven?
Comments
Comment #1
markhalliwellAt first glance and after dig around a bit, I can't see why this is happening (it returning a string instead of an array). It should be an array... I'll have to dig in deeper when I have the time.
Comment #10
quietone CreditAttribution: quietone as a volunteer commentedTriaging for Bugsmas.
Looking at the date, it seems this was filed against Drupal 8.0-alpha2 or alpha3. I didn't find the color update tests being referred to but there was a color_update_8001(), which was removed in #2168011: Remove all 7.x to 8.x update hooks and disallow updates from the previous major version, when Drupal 8 was still in alpha. That was 6 years ago and Drupal 9 has been released. Any updates have already happened an no testing is needed.
I think this can be closed as outdated.