Had to run update.php to test a patch. Database upgrades succesfull. The final screen with link back to administration pages, that link takes me back to the start of update.php. Should probably be "/admin" but right now is /core/update.php/admin.

CommentFileSizeAuthor
#11 d8_update_links.png59.34 KBjlbellido
#10 Wrong_link_to_admin_pages_after_succesful_update-2020141-10.patch677 bytesmarcoscano
#9 Wrong_link_to_admin_pages_after_succesful_update.patch679 bytessuhel.rangnekar
#4 update-wrong_links_fix-2020141-4.patch768 bytesJeroenT
wrong-admin-pages-link.png157.12 KByoroy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yoroy’s picture

yoroy CreditAttribution: yoroy commented

yoroy’s picture

yoroy CreditAttribution: yoroy commented
Component: update.module » base system
Issue tags: +Novice

Tagging, changing component.

amateescu’s picture

amateescu CreditAttribution: amateescu commented

I encountered this as well with the 'Front page' link which was redirecting back to update.php.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Status: Active » Needs review
FileSize
update-wrong_links_fix-2020141-4.patch768 bytes

Fixed the wrong links. Patch attached.

Status: Needs review » Needs work

The last submitted patch, update-wrong_links_fix-2020141-4.patch, failed testing.

pleone’s picture

pleone CreditAttribution: pleone commented
Status: Needs work » Needs review

We tested it again locally and the test passed.

DarthDrupal’s picture

DarthDrupal CreditAttribution: DarthDrupal commented
Issue tags: -Novice

#4: update-wrong_links_fix-2020141-4.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice

The last submitted patch, update-wrong_links_fix-2020141-4.patch, failed testing.

suhel.rangnekar’s picture

suhel.rangnekar CreditAttribution: suhel.rangnekar commented
Assigned: Unassigned » suhel.rangnekar
Status: Needs work » Needs review
FileSize
Wrong_link_to_admin_pages_after_succesful_update.patch679 bytes

Updated correct link for "Front page" and "Administration pages" links.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
CreditAttribution: marcoscano commented
FileSize
Wrong_link_to_admin_pages_after_succesful_update-2020141-10.patch677 bytes

I tested the patch in #9 and it works fine.

Just note that you add a couple of trailing blank spaces on line 170 of update.php

Attached a modified version of it with no trailing spaces

jlbellido’s picture

jlbellido
Primary language Spanish
CreditAttribution: jlbellido commented
Status: Needs review » Reviewed & tested by the community
FileSize
d8_update_links.png59.34 KB

I have applied #10 and it works for me!

Dries’s picture

Dries CreditAttribution: Dries commented 
+++ b/core/update.phpundefined
@@ -166,14 +166,16 @@ function update_script_selection_form($form, &$form_state) {
-      'href' => 'admin',

What if clean URLs aren't enabled?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Closed (duplicate)

This is a duplicate of #2017769: Links from update_helpful_links() should point to site root and not to update.php.. the patch is identical...

I'll ensure that people who have worked on this patch get a commit credit on the other....

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

Also see #2017769-8: Links from update_helpful_links() should point to site root and not to update.php for how the patch can be improved...