Rename Views method mark_table() to markTable()

taking it with sillygwailo

adding patch

rerolling with access modifier

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -466,7 +466,7 @@ function queue_table($table, $relationship = NULL, JoinPluginBase $join = NULL,
+  public function markTable($table, $relationship, $alias) {

I can't think of a reason why someone would need this as public method. Can you think of one?

Should be protected :)

I couldn't find the reason to make it protected as well, this method has two calls from its own class' member. I guess it should be fine to keep it private.

NEVER make anything private inside views. there are 1000 use cases where you need to extend the classes defined in core. When you make function private it's a lot harder to extend these classes.

@aspilicious thank you, appreciate the quick response. you saved me, I was about to create patch as private.

setting to needs review so someone can take a look at the latest patch

public ==> protected.

I looked at the latest patch. Fix that and this is ok :)

@aspilicious ok.so re-rolling patch in #3 as protected

Thank you!

no problem :)

#11: 2003514_rename-view-method-mark_table_11.patch queued for re-testing.

thank you!

Thanks for review!

Committed and pushed to 8.x. Thanks!

Moving to Views for the change notice.

We'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.