Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#15 | views-core-rename-show-build-group-button-2003266-15.patch | 1.09 KB | SpartyDan |
#13 | drupal-rename_show_build_group_button-2003266-13.patch | 1.09 KB | iStryker |
#13 | interdiff.txt | 640 bytes | iStryker |
#4 | 2003266_changetoCamelCase.patch | 1.15 KB | misselbeck |
#3 | drupal-rename-show-build-group-button-2003266-2.patch | 1.08 KB | kenianbei |
Comments
Comment #1
kenianbei CreditAttribution: kenianbei commentedComment #2
misselbeck CreditAttribution: misselbeck commentedWorking on DrupalCon 2013 Sprint
Comment #3
kenianbei CreditAttribution: kenianbei commentedComment #4
misselbeck CreditAttribution: misselbeck commentedComment #5
misselbeck CreditAttribution: misselbeck commentedOoops...double patch.
Comment #6
kenianbei CreditAttribution: kenianbei commentedNo problem, just make sure that the issue hasn't been taken by someone before you take it on. You also should check out this page on patch naming conventions: http://drupal.org/node/707484
Comment #8
heddnFailing tests. Please test and re-roll.
Comment #9
iStryker CreditAttribution: iStryker commented#3: drupal-rename-show-build-group-button-2003266-2.patch queued for re-testing.
Comment #10
iStryker CreditAttribution: iStryker commentedShouldn't the function be rename as either a public or a protected function?
Comment #11
heddnIf it is only used internally i.e. $this->{foo} then protected seems appropriate. Otherwise use public.
Comment #12
oenie CreditAttribution: oenie commented#4: 2003266_changetoCamelCase.patch queued for re-testing.
Comment #13
iStryker CreditAttribution: iStryker commentedFollowing @heddn advice, making the function public.
Comment #14
dawehnerFollowing the advice of heddn I would argue to make it protected.
I also can't see a reason why this method would be called outside of filters.
Comment #15
SpartyDan CreditAttribution: SpartyDan commentedfunction changed to protected
Comment #16
aspilicious CreditAttribution: aspilicious commentedComment #17
alexpottCommitted 51777f2 and pushed to 8.x. Thanks!