Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#8 views_rename_showSortForm-2003258-8.patch690 bytesmarkie
#3 rename_showSortForm-2003258-3.patch1.09 KBmarkie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markie’s picture

markie CreditAttribution: markie commented
Assigned: Unassigned » markie
markie’s picture

markie CreditAttribution: markie commented

dibs

markie’s picture

markie CreditAttribution: markie commented
Status: Active » Needs review
FileSize
rename_showSortForm-2003258-3.patch1.09 KB

patched

phl3tch’s picture

phl3tch CreditAttribution: phl3tch commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed acd9be1 and pushed to 8.x. Thanks!

iStryker’s picture

iStryker CreditAttribution: iStryker commented
Status: Fixed » Needs review

Shouldn't the function be public or private?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Needs work

Right it should be protected.

markie’s picture

markie CreditAttribution: markie commented
Status: Needs work » Needs review
FileSize
views_rename_showSortForm-2003258-8.patch690 bytes

access updated per request.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed dd4f441 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.