Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#2 views-default_display_options_rename-2002450-2.patch7.36 KBjazzdrive3
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jazzdrive3’s picture

jazzdrive3 CreditAttribution: jazzdrive3 commented
Assigned: Unassigned » jazzdrive3
jazzdrive3’s picture

jazzdrive3 CreditAttribution: jazzdrive3 commented
FileSize
views-default_display_options_rename-2002450-2.patch7.36 KB

Patch is attached. Tests have passed fine on my install.

jazzdrive3’s picture

jazzdrive3 CreditAttribution: jazzdrive3 commented
Status: Active » Needs review

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views-default_display_options_rename-2002450-2.patch, failed testing.

jazzdrive3’s picture

jazzdrive3 CreditAttribution: jazzdrive3 commented
Status: Needs work » Needs review

#2: views-default_display_options_rename-2002450-2.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, views-default_display_options_rename-2002450-2.patch, failed testing.

jazzdrive3’s picture

jazzdrive3 CreditAttribution: jazzdrive3 commented
Status: Needs work » Needs review

re-testing, as this should not have failed.

jazzdrive3’s picture

jazzdrive3 CreditAttribution: jazzdrive3 commented

#2: views-default_display_options_rename-2002450-2.patch queued for re-testing.

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed c1d7f6f and pushed to 8.x. Thanks!

jazzdrive3’s picture

jazzdrive3 CreditAttribution: jazzdrive3 commented

Just curious, because parts of git are still a mystery to me, as well as how this process works. Why is Alex Pott listed as the author of the commit, when I did a format-patch with the proper author attribution tag?

Automatically closed -- issue fixed for 2 weeks with no activity.