Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#10 | drupal_rename_cache_set-2002410-10.patch | 2.21 KB | nathangervais |
#8 | drupal_rename_cache_set-2002410-8.patch | 2.14 KB | nathangervais |
#6 | drupal_rename_cache_set-2002410-6.patch | 2.69 KB | nathangervais |
#4 | drupal_rename_cache_set-2002410-4.patch | 2.2 KB | nathangervais |
#2 | 2002410.patch | 750 bytes | davmorr |
Comments
Comment #1
davmorr CreditAttribution: davmorr commentedComment #2
davmorr CreditAttribution: davmorr commentedChanged cache_set() to cacheSet()
Comment #3
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the function to adher to the new OOP standards.
Comment #4
nathangervais CreditAttribution: nathangervais commentedRerolled patch to include the public access modifier and also found more occurances of this call in other files. They have been updated.
There was also a reference in a comment in core\modules\views\views.module on line 1681 that i have left unchanged as I wasnt sure this applied to this instance.
This is just a convenience wrapper around cache_set().
Comment #5
heddnGo ahead and change the comment as well.
Comment #6
nathangervais CreditAttribution: nathangervais commentedPatch rerolled with comment modified.
Comment #7
dawehnerLet's use {@inheritdoc}
That's out of scope because it's another cache_set meant.
Comment #8
nathangervais CreditAttribution: nathangervais commentedAs near as I can tell you're asking for the entire comment block on the cacheSet function in /core/modules/views/lib/Drupal/views/Plugin/views/cache/None.php to be set to { @inheritdoc } as per https://drupal.org/node/1962592
With that assumption i've rolled this rerolled this patch to update that reference and remove the comment change in views.module.
Comment #9
dawehnerThis contained some actual helpful information.
Let's keep this line as it explains something. Btw. it should be "... does not set a cache item at all."
Comment #10
nathangervais CreditAttribution: nathangervais commentedRerolled Patch, readded the comment with addition of the word not.
Comment #11
dawehnerThank you very much!
Comment #12
alexpottCommitted a17c65c and pushed to 8.x. Thanks!