Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#16 | 2002368-16-rename-build_condition.patch | 622 bytes | elvis2 |
#7 | drupal-camelcase_replace-2002368-7.patch | 1.26 KB | baldwinlouie |
#2 | drupal-camelcase_replace-2002368-7450032.patch | 1.25 KB | baldwinlouie |
Comments
Comment #1
baldwinlouie CreditAttribution: baldwinlouie commentedtaking it: baldwinlouie and sillygwailo
Comment #2
baldwinlouie CreditAttribution: baldwinlouie commentedattaching patch
Comment #3
baldwinlouie CreditAttribution: baldwinlouie commentedComment #5
baldwinlouie CreditAttribution: baldwinlouie commented#2: drupal-camelcase_replace-2002368-7450032.patch queued for re-testing.
Comment #6
oenie CreditAttribution: oenie commentedAdd protected access modifier in front of the function to adher to the new OOP standards.
Comment #7
baldwinlouie CreditAttribution: baldwinlouie commentedre-rolling the patch
Comment #9
baldwinlouie CreditAttribution: baldwinlouie commented#7: drupal-camelcase_replace-2002368-7.patch queued for re-testing.
Comment #11
SpartyDan CreditAttribution: SpartyDan commented#7: drupal-camelcase_replace-2002368-7.patch queued for re-testing.
Comment #12
oenie CreditAttribution: oenie commentedLooks good to me now !
Comment #13
elvis2 CreditAttribution: elvis2 commentedShould the access modifier on this function be protected or public?
Comment #14
heddnIf the method is only used internally i.e. $this->{foo}, then I'd recommend protected. Otherwise, go with public as it needs to be usable by folks outside the class is apart of the public API.
Comment #15
alexpottCommitted 7ab5c07 and pushed to 8.x. Thanks!
Comment #16
elvis2 CreditAttribution: elvis2 commentedThis patch only changes the function from protected to public, based on #14.
Comment #17
dawehnerI don't think we need this to be public.
Comment #18
elvis2 CreditAttribution: elvis2 commented@dawehner, thanks for chiming in.