Use Symfony Request for views module [#1999450]

Part of #1998638: Replace almost all remaining superglobals ($_GET, $_POST, etc.) with Symfony Request object

Files that need converting are:

core/modules/views/includes/ajax.inc
core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.php
core/modules/views/lib/Drupal/views/Plugin/views/display/DisplayPluginBase.php
core/modules/views_ui/lib/Drupal/views_ui/ViewEditFormController.php
core/modules/views_ui/lib/Drupal/views_ui/ViewUI.php

Comment	File	Size	Author
#8	1999450_8-replace-raw-variables-views.patch	1.78 KB	aaronott
#8
#8	1999450_-replace-raw-variables-views_interdiff.txt	921 bytes	aaronott
#6	1999450_6-replace-raw-variables-views.patch	1.69 KB	aaronott
#6
#4	1999450_4-replace-raw-variables-views.patch	1.69 KB	aaronott
#4
#4	1999450-replace-raw-variables-views.innerdiff.txt	763 bytes	aaronott
#2	1999450_2-replace-raw-variables-views.patch	1.69 KB	aaronott
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

aaronott CreditAttribution: aaronott commented 24 May 2013 at 17:58

Assigned:

Unassigned

» aaronott

Starting the conversion.

Comment #2

aaronott CreditAttribution: aaronott commented 24 May 2013 at 18:46

Assigned:	aaronott	» Unassigned
Status:	Active	» Needs review

File	Size
1999450_2-replace-raw-variables-views.patch	1.69 KB

Comment #3

damiankloip CreditAttribution: damiankloip commented 24 May 2013 at 18:56

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -290,8 +290,8 @@ public function generateResultsKey() {
+        if (Drupal::request()->query->get($key)) {
+          $key_data[$key] = Drupal::request()->query->get($key);

We call that method twice here, we should use ->has($key) instead, or assign it to a variable first to re use.

Comment #4

aaronott CreditAttribution: aaronott commented 24 May 2013 at 19:38

File	Size
1999450-replace-raw-variables-views.innerdiff.txt	763 bytes
1999450_4-replace-raw-variables-views.patch	1.69 KB

I switched this to the ->has($key)

Comment #5

25 May 2013 at 01:02

Status:

Needs review

» Needs work

The last submitted patch, 1999450_4-replace-raw-variables-views.patch, failed testing.

Comment #6

aaronott CreditAttribution: aaronott commented 25 May 2013 at 01:39

Status:

Needs work

» Needs review

File	Size
1999450_6-replace-raw-variables-views.patch	1.69 KB

Again with PSR-0

Comment #7

kim.pepper

English

🏄‍♂️🇦🇺Sydney, Australia

CreditAttribution: kim.pepper commented 1 June 2013 at 21:54

Status:

Needs review

» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -290,8 +290,8 @@ public function generateResultsKey() {
+          $key_data[$key] = Drupal::request()->query->get($key);

This needs to be namespaced as well in PSR-0. Should be \Drupal.

We should also create a $query variable to be re-used.