Comments

chertzog’s picture

Assigned: Unassigned » chertzog
Status: Active » Needs review
StatusFileSize
new1.79 KB

Status: Needs review » Needs work

The last submitted patch, 1999394_1-replace-raw-variables-locale.patch, failed testing.

chertzog’s picture

Status: Needs work » Needs review
StatusFileSize
new1.79 KB
kim.pepper’s picture

Status: Needs review » Needs work
+++ b/core/modules/locale/locale.pages.incundefined
@@ -65,17 +65,19 @@ function locale_translate_filter_load_strings() {
+      $request = $query->get($key);
+      if (!empty($request)) {

$request isn't the right variable name to use here. Let's use $filterParam instead.

Also, we can use $request->has($key) instead.

+++ b/core/modules/locale/locale.pages.incundefined
@@ -445,10 +447,10 @@ function locale_translate_edit_form_submit($form, &$form_state) {
+  $query = Drupal::request()->query->get('page');

$query isn't the right variable name to use. How about $pageParam.

+++ b/core/modules/locale/locale.pages.incundefined
@@ -445,10 +447,10 @@ function locale_translate_edit_form_submit($form, &$form_state) {
+  if (!empty($query)) {

We can use $request->has('blah');

aaronott’s picture

Status: Needs work » Needs review
StatusFileSize
new1.67 KB
new1.85 KB

Added some changes suggested in #4

marcingy’s picture

star-szr’s picture

Assigned: chertzog » Unassigned
Status: Needs review » Needs work
Issue tags: +Needs reroll

This needs a reroll.

linl’s picture

Status: Needs work » Closed (duplicate)
Issue tags: -Needs reroll

This code was refactored in #1978916: Convert locale_translate_page to a Controller, so closing this as a duplicate.

star-szr’s picture

Great, thanks!