Convert language_test_subrequest() to a new style controller

Converted this one. Not sure if this should be added to the existing LanguageTestController or should have an extra controller, because this is the only one that needs the http_kernel service.

+++ b/core/modules/language/tests/language_test/language_test.routing.ymlundefined
@@ -11,3 +11,10 @@ language_test_theme_link_active_class:
+    _content: '\Drupal\language_test\Controller\LanguageTestController::testSubRequest'

Just wondering whether it makes sense to use content when there is a subrequest anyway which will trigger the HtmlPageController anyway.

+++ b/core/modules/language/tests/language_test/lib/Drupal/language_test/Controller/LanguageTestController.phpundefined
@@ -16,10 +18,27 @@
+    $this->http_kernel = $http_kernel;

Should be better $this->httpKernel

+++ b/core/modules/language/tests/language_test/lib/Drupal/language_test/Controller/LanguageTestController.phpundefined
@@ -110,4 +129,11 @@ public function lActiveClass() {
+   * Uses a subrequest to retrieve the 'user' page.
...
+  public function testSubRequest() {

Needs @return

Thanks for the review!

Just wondering whether it makes sense to use content when there is a subrequest anyway which will trigger the HtmlPageController anyway.

Right. I wasn't aware there is anything else than _content when I wrote the patch.

Also fixed the variable name and the missing @return.

Forgot this hunk:

-   * @param \Symfony\Component\HttpKernel\HttpKernelInterface $http_kernel
+   * @param \Symfony\Component\HttpKernel\HttpKernelInterface $httpKernel

+++ b/core/modules/language/tests/language_test/lib/Drupal/language_test/Controller/LanguageTestController.phpundefined
@@ -16,10 +18,27 @@
    * Implements \Drupal\Core\ControllerInterface::create().

Just in case there is a rerole needed, let's use {@inheritdoc}

Needs a reroll

curl https://drupal.org/files/1987728-language-test-subrequest-controller-5.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3619  100  3619    0     0   4771      0 --:--:-- --:--:-- --:--:--  6218
error: patch failed: core/modules/language/tests/language_test/language_test.module:97
error: core/modules/language/tests/language_test/language_test.module: patch does not apply

Seems straightforward enough to me.

And again...

curl https://drupal.org/files/1987728-language-test-subrequest-controller-8.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4908  100  4908    0     0   1910      0  0:00:02  0:00:02 --:--:--  2075
error: patch failed: core/modules/language/tests/language_test/lib/Drupal/language_test/Controller/LanguageTestController.php:9
error: core/modules/language/tests/language_test/lib/Drupal/language_test/Controller/LanguageTestController.php: patch does not apply

And again...

Committed dec3e5c and pushed to 8.x. Thanks!

Retroactive tags :)