Problem/Motivation
There are the things in the Add blocks page (Block library listing) which are block plugins. Those hold the description and the body. (for custom block, basic block type). Then there are other things on the Blocks admin listing. Those are block instances of those block plugins.
The dropdown buttons on the blocks in the UI on the site, inplace in the regions, have items in the dropbutton list. Some of those items deal with the block plugin: edit, delete. Some deal with the block (block instance): configure.
Also, on the block admin list, the dropbutton there on the admin list has items: configure, delete. *Those* deal with just the block instance. So it seems similar to the dropbottom that is inplace on the block there. This is confusing because it seems like you can do more from the inplace dropdown than in the admin list.
Both dropdowns have a delete, but the inplace delete deletes the plugin, not the block instance, the block admin list dropdown delete.
Proposed resolution
Make the dropbutton on the block admin list have the same things as the inplace dropbutton.
But.. make it clear that some of those effect just the row (which is the block instance) and some effect the block plugin (where the description comes from).
Add to the dropbutton: 'Edit plugin' and 'Delete plugin', optionally change the 'Delete' there to 'Delete block' and 'Configure' to 'Configure block'
Remaining tasks
- Discuss.
- Create initial patch to change the dropbutton.
- more tasks to come later...
User interface changes
Yes. Change the dropbutton on blocks in the block admin list.
API changes
No API changes.
Related Issues
- #1956496: Custom block contextual links should differentiate between editing/deleting the block instance and the custom block entity
- #1956504: Add block instance delete to block contextual links
- #1956448: Use the block instance title on the block admin listing
- #1956362: Name the page that lists block plugins, now: Blocks and Add Blocks, better: Block Library
- #1871746: Add modal block browser
- #1888702: Use configuration selection instead of derivatives for some blocks
- #1535868: Convert all blocks into plugins
Comment | File | Size | Author |
---|---|---|---|
#3 | with_edit.png | 227.02 KB | YesCT |
#2 | inplace.png | 44.46 KB | YesCT |
#2 | block_admin_before.png | 187.32 KB | YesCT |
Comments
Comment #1
YesCT CreditAttribution: YesCT commentedfixing title.
Comment #1.0
YesCT CreditAttribution: YesCT commentedadded issue about inplace being clear about which actions effect the plugin and which effect the block isntance.
Comment #1.1
YesCT CreditAttribution: YesCT commentedadded issue about adding the delete to the inplace dropdown
Comment #2
YesCT CreditAttribution: YesCT commentedinplace:
block admin list:
Comment #3
YesCT CreditAttribution: YesCT commentedproposed:
(this shows it with two deletes. if the plugin delete should not be here, it should also be removed from the inplace one too. #1956504: Add block instance delete to block contextual links would make there two deletes on the inplace on also, as it adds the delete to delete the instance there. )
Comment #4
xjm"Edit plugin" and "Delete plugin" don't make sense. A plugin is a code definition of the block (its settings, behavior, etc.) in the codebase. I don't understand from the screenshots or the issue description what these links would do. Anyway, plugin isn't a word we should ever expose to the user.
Also, the thing in the screenshot with the little pencil is the block's contextual links. Different from dropbuttons. :)
I think what you are asking for is similar to #1956134: Provide helpful editing links on "admin/structure/block" for deriver blocks (menu, views, block content, etc.)? The derivative definition source, e.g. the menu, view, etc.? If so, the new dropbutton operations should then say, e.g., "Edit menu" or "Edit view" or "Edit block content" (for custom blocks).
Comment #5
xjmOops, only half-finished retitling
Comment #6
xjmI think this is a duplicate of #1956134: Provide helpful editing links on "admin/structure/block" for deriver blocks (menu, views, block content, etc.) actually.
Comment #7
xjmComment #7.0
xjmadded issue about what block plugins are called