Problem/Motivation

There are the things in the Add blocks page (Block library listing) which are block plugins. Those hold the description and the body. (for custom block, basic block type). Then there are other things on the Blocks admin listing. Those are block instances of those block plugins.

The dropdown buttons on the blocks in the UI on the site, inplace in the regions, have items in the dropbutton list. Some of those items deal with the block plugin: edit, delete. Some deal with the block (block instance): configure.

Also, on the block admin list, the dropbutton there on the admin list has items: configure, delete. *Those* deal with just the block instance. So it seems similar to the dropbottom that is inplace on the block there. This is confusing because it seems like you can do more from the inplace dropdown than in the admin list.

Both dropdowns have a delete, but the inplace delete deletes the plugin, not the block instance, the block admin list dropdown delete.

Proposed resolution

Make the dropbutton on the block admin list have the same things as the inplace dropbutton.
But.. make it clear that some of those effect just the row (which is the block instance) and some effect the block plugin (where the description comes from).

Add to the dropbutton: 'Edit plugin' and 'Delete plugin', optionally change the 'Delete' there to 'Delete block' and 'Configure' to 'Configure block'

Remaining tasks

  • Discuss.
  • Create initial patch to change the dropbutton.
  • more tasks to come later...

User interface changes

Yes. Change the dropbutton on blocks in the block admin list.

API changes

No API changes.

Related Issues

CommentFileSizeAuthor
#3 with_edit.png227.02 KBYesCT
#2 inplace.png44.46 KBYesCT
#2 block_admin_before.png187.32 KBYesCT
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

YesCT’s picture

Title: Copy of use the block instance title on the block admin listing » Have dropbutton from block admin list page be as powerful as the inplace dropbutton on a block (add edit)

fixing title.

YesCT’s picture

Issue summary: View changes

added issue about inplace being clear about which actions effect the plugin and which effect the block isntance.

YesCT’s picture

Issue summary: View changes

added issue about adding the delete to the inplace dropdown

YesCT’s picture

FileSize
187.32 KB
44.46 KB

inplace:
inplace.png

block admin list:
block_admin_before.png

YesCT’s picture

FileSize
227.02 KB

proposed:
(this shows it with two deletes. if the plugin delete should not be here, it should also be removed from the inplace one too. #1956504: Add block instance delete to block contextual links would make there two deletes on the inplace on also, as it adds the delete to delete the instance there. )

with_edit.png

xjm’s picture

Title: Have dropbutton from block admin list page be as powerful as the inplace dropbutton on a block (add edit) » Add "edit" top block admin list page be as powerful as the contextual links on a block (add edit)

"Edit plugin" and "Delete plugin" don't make sense. A plugin is a code definition of the block (its settings, behavior, etc.) in the codebase. I don't understand from the screenshots or the issue description what these links would do. Anyway, plugin isn't a word we should ever expose to the user.

Also, the thing in the screenshot with the little pencil is the block's contextual links. Different from dropbuttons. :)

I think what you are asking for is similar to #1956134: Provide helpful editing links on "admin/structure/block" for deriver blocks (menu, views, block content, etc.)? The derivative definition source, e.g. the menu, view, etc.? If so, the new dropbutton operations should then say, e.g., "Edit menu" or "Edit view" or "Edit block content" (for custom blocks).

xjm’s picture

Title: Add "edit" top block admin list page be as powerful as the contextual links on a block (add edit) » Add "edit" to dropbuttons on the block admin page

Oops, only half-finished retitling

xjm’s picture

xjm’s picture

Status: Active » Closed (duplicate)
xjm’s picture

Issue summary: View changes

added issue about what block plugins are called