Problem
While building the translation UIs for configuration entities I found out that many configuration entity properties are improperly typed, the label and text types are not well used and therefore some configuration entities cannot have a translation UI generated, because they have no translatable schema properties. (This also means these will not be exported for translation on localize.drupal.org).
The properties I noticed so far:
- contact category labels and autoreply text
- menu label (and the description is mistyped ad text, while it is actually also a label now, not multiline)
- filter format label
- user role label
- shortcut set label
Fixing these would make config_translation properly expose translation UIs for these config entities as tabs on their configuration pages (and operations in their proper listing screens).
Proposal
Apply the label type properly to these. Check with http://drupal.org/project/config_translation that it properly works (should result in translation operations on these objects work).
Comment | File | Size | Author |
---|---|---|---|
#6 | 1947810-string-label-types-config-schema-fix-6.patch | 2.65 KB | vijaycs85 |
#6 | 1947810-diff-3-6.txt | 1.43 KB | vijaycs85 |
#3 | 1947810-string-label-types-config-schema-fix-1.patch | 3.58 KB | vijaycs85 |
Comments
Comment #1
Gábor HojtsyPutting this on D8MI sprint since it affects the translation UI for these *immensely* (now most of these have a translation UI with access denied since no translatable properties exist).
Comment #2
vijaycs85Updating for all in description. One additional change is comment capitalization of module name in Shortcut module, which I think fine to go with this patch.
Comment #3
vijaycs85Updating for all in description. One additional change is comment capitalization of module name in Shortcut module, which I think fine to go with this patch.
Comment #4
vijaycs85Crosspost... adding tag back
Comment #5
Gábor HojtsyI'd be shocked if the list of roles on filter formats would be labels. They are machine names I'm sure.
These are also machine names, should keep being strings, right?
This is a machine name too, no? Also "l" would be bugos anyway.
Comment #6
vijaycs85Updating as per #5.
Comment #7
Gábor HojtsyYay, this patch fixes translatability all across the modules it affects. Contact, roles, menus, etc. Example screenshots for contact with the http://drupal.org/project/config_translation module:
and
Prior to this patch these did not work since there were no translatable types used. The effect is the same for shortcut sets, user roles, text formats and so on. Good stuff!
Comment #8
Gábor HojtsyAdd more tags relevant to the issue.
Comment #9
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.
Comment #10
Gábor HojtsyThanks, this unlocked manual user interface based translations for a lot of stuff! Thanks!