This is a sub-issue of #1938580: [META] Make active config save format match the default yml file (order and quotes). Check meta issue for Steps to reproduce and Coding standards

Files fixed already
filter.settings.yml

Files need to be fixed
filter.format.plain_text.yml

Remaining tasks

CommentFileSizeAuthor
#3 1942122-filter-config-format-3.patch449 bytessandipmkhairnar
#2 2013-03-16_163624.png27.99 KBvijaycs85
#2 2013-03-16_163608.png60.56 KBvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sandipmkhairnar’s picture

sandipmkhairnar CreditAttribution: sandipmkhairnar commented

I think filter.format.plain_text.yml file looks good. No need to change.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Needs work
FileSize
2013-03-16_163608.png60.56 KB
2013-03-16_163624.png27.99 KB

Guess user roles should be removed for this format as there is no option we can change it? Please refer screenshots:
2013-03-16_163624.png

2013-03-16_163608.png

sandipmkhairnar’s picture

sandipmkhairnar CreditAttribution: sandipmkhairnar commented
FileSize
1942122-filter-config-format-3.patch449 bytes

Thanks @vijaycs85 for review.

Created patch as per comment.

sandipmkhairnar’s picture

sandipmkhairnar CreditAttribution: sandipmkhairnar commented
Status: Needs work » Needs review
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Issue tags: -Configuration system, -Config novice

#3: 1942122-filter-config-format-3.patch queued for re-testing.

SwapS’s picture

SwapS CreditAttribution: SwapS commented
Issue tags: +Configuration system, +Config novice

#3: 1942122-filter-config-format-3.patch queued for re-testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Closed (duplicate)

Actually, those roles values are needed. We have a test for that, if you tried to remove the roles from filter.format.filter_test.yml, this would fail:

http://drupalcode.org/project/drupal.git/blob?f=core/modules/filter/lib/...

These files are being updated as a part of the much larger #1868772: Convert filters to plugins, I'm closing this as a duplicate.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue summary: View changes

Updated issue summary.