Task

Use Twig instead of PHPTemplate

To test this code:

Apply patch, set default theme to Stark, clear cache if necessary, click around to make sure theme still works.

#1938864: [meta] Update all core themes to use Twig
#1757550: [Meta] Convert core theme functions to Twig templates

CommentFileSizeAuthor
#2 core-stark-engine-1938854-1.patch388 bytesTommyK
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

star-szr’s picture

Issue tags: +Novice

Adding novice tag, we just need a one-line patch that adds engine: twig to stark.info.yml. Great task for someone new to git or contributing to Drupal :)

TommyK’s picture

Status: Active » Needs review
FileSize
388 bytes

I added engine: twig after the core: 8.x line like D6 themes had.

chrisjlee’s picture

@Cottser: Does this particular task need a test written?

star-szr’s picture

Status: Needs review » Reviewed & tested by the community

Thanks @TommyK, that's perfect!

@chrisjlee - No, the patch in #2 is all we need in this issue. We don't need Stark-specific tests, and we already have Twig tests in core.

nikkubhai’s picture

#2: core-stark-engine-1938854-1.patch queued for re-testing.

nikkubhai’s picture

Issue summary: View changes

Add core themes meta

star-szr’s picture

Status: Reviewed & tested by the community » Closed (duplicate)

As it turns out we're changing the default theme engine in #1806478: Make twig the default engine once all modules templates are converted from .tpl.php to .html.twig which will be a part of the big conversion patch at #1987510: [meta] Convert all core *.tpl.php templates to Twig as singular patch, so closing this one. Thanks everyone!

Edit: to be clear this line won't need to change, that's why I'm closing this one :)

star-szr’s picture

Issue summary: View changes

Updated issue summary.