Add a language selector on views

How does this relate to the content actually in the view?

For example, if a view contains a listing of Hungarian language nodes, but the View is set to English.

Does this language relate to the labels, titles, and other properties of the View, as opposed to its results?

@cam8001 description of the element says "Language of the labels and other textual elements in this view". So looks like, it is for properties of view.

That's great. I'm wondering whether we should adapt all test views configs as well, but that feels like a little too much.

During testing I had an issue with language module disabled, which is fine, but the question is whether this code should be wrapped with an module_exists?
Other places like the node edit form doesn't do it, so this seems fine.

Added a small adaption to one of the tests.

Is this per view, or per display?

Yeah it got green. As gabor didn't had something to complain about that test, this feels RTBC. @YesCT: Do you want to have the honor? :)

looks ok for me

I can't look at it till later tonight, so, proceed. :)

I already double checked.. I'll tripple check later.

But:

 661 sudo rm -r sites
  662  git checkout sites
  663  git status
  664  git add core*
  665  git commit -m "patch"
  666  drush -y si --account-pass=admin --db-url="mysql://root:root@localhost/d8-patch" --site-name=8.x
  667  mvim core/modules/views/config/views.view.frontpage.yml
  668  mvim sites/default/files/config_p90OzGn6UalqnTGU2hRUzsTID5ByjLqrPbA4V7c8icc/active/views.view.frontpage.yml 

http://screencast.com/t/9mmej4sc

I dont see the langcode in the .yml file for the active config.

Ah, talked to @Gábor Hojtsy in irc, and he pointed out it might be at the end of the active config file. it was.

$ diff core/modules/views/config/views.view.frontpage.yml sites/default/files/config__rzyR0s0KXhc9jjr4I7HQl3nK300t-85ew12vzYGO2A/active/views.view.frontpage.yml

1,6c1
< langcode: en
< status: '0'
< module: node
< id: frontpage
< description: 'Emulates the default Drupal front page; you may set the default home page path to this view to make it your front page.'
< tag: default
---
> base_field: nid
8d2
< human_name: 'Front page'
9a4,5
> description: 'Emulates the default Drupal front page; you may set the default home page path to this view to make it your front page.'
> status: '0'
20c16
<           query_comment: false
---
>           query_comment: '0'
34c30
<           links: 1
---
>           links: '1'
54c50
<           group: 0
---
>           group: '0'
56c52
<             operator: false
---
>             operator: '0'
63c59
<           group: 0
---
>           group: '0'
65c61
<             operator: false
---
>             operator: '0'
87c83
<         title: false
---
>         title: '0'
99a96,101
> human_name: 'Front page'
> module: node
> id: frontpage
> tag: default
> uuid: 70e7b744-0224-4f63-b800-a9843b3433d3
> langcode: en

I think this is *not* a problem with this issue, but a separate issue. I'll open that separate issue. There were similar things found while working on the schema issues, so I'll link those to see what we did for them, in terms of ensuring that the save is repeatable: that the order is the same each time it's saved.

steps to test

1. fresh git pull --rebase
2. sudo rm -r sites
3. git checkout sites
4. drush si (or drop tables in db and install by hand)
5. enable the language module
6. add a language
7. add a view

uh, I dont get the page as shown above...
I get:

continuing the steps.

8. save the view [edit: added screenshot]

in the active config, the yml for that view ends like:

    display_options:
      path: first-test
human_name: first_test
module: views
id: first_test
tag: ''
uuid: e1990aa7-8b5e-43dc-ac13-19d08c6ed5a2
langcode: und

should that be en?

best practices and 80% thoughts

note, from irc with @Gábor Hojtsy

a site building best practice is you create the view in the site default and translate from there with exceptions only for those which only apply to specific languages (much less likely)

So that is a reason for *not* showing the language select in the add view.

9. the view

10. edit the name to change the language

that is .. strange. will need to change the button to name/description/language? that's a little long for a button name. it's also the place to change the tag.
Lets change the button to something like: change the overall view information. Hm. I'll think more on that in a bit.

11. language options in select

11 a.

Should the language options here be similar to those allowed on content?
Maybe they are...
Oh, I was thinking of this drop down on the default language selection. That is (for content) the select for picking the default language, not the actual language select.

11 b.

11 c.
Do we want to include Not specified and Not applicable ?

cross posted with Gabor.

Needs work to make the view be created in the site default language.

Let's do that.

That's indeed a good idea.

Added a general test for wizard plugin base.

Well yeah, the views_fetch_fields() method is part of admin.inc, so you have to include it. As a wizard should work without external setup,
I think these lines make sense here.

Alternative it would be for sure also possible to just include the file in the test, but this feels worse.

Well, there for sure is one :)

http://api.drupal.org/api/drupal/core%21modules%21views%21views_ui%21adm...

1. Installed D8 from fresh git clone (in English)
2. Added Configuartion inspector module
3. Enabled the Language, Interface translation, Content translation and Configuration inspector modules
4. Added a new language (Hungarian)
5. Applied the patch from #1935022-35: Add a language selector on views
6. Created a new view
7. Inspected the yml file of the view. It has 'langcode' => 'en', in it, which means the default language of the site.

I think we are OK. :)

Oh right.

+++ b/core/modules/node/config/views.view.frontpage.ymlundefined
@@ -3,6 +3,7 @@ base_table: node
 core: 8.x
 description: 'A list of nodes marked for display on the front page.'
 status: '1'
+langcode: 'en'

Perhaps langcode and status should be at the top of the file, as in other files?

Otherwise, if no standard is defined, this looks like its good to go.

Yeah that's a good idea.

In general it seems to be that we want to move the entity ID to the top as well, but sure this is out of the scope of this issue.

Looks super to me now.

Following steps from #37 one more time - more or less.

1. Apply patch #42
2. Install in English
3. Enable the Language, Interface translation, Content translation and Configuration inspector extensions
4. Added additional language (Czech)
5. Created test view. (yml output below)
6. Langcode 'en' is appended to the end of the file.

base_field: nid
base_table: node
core: 8.x
description: ''
status: '1'
display:
  default:
    display_plugin: default
    id: default
    display_title: Master
    position: ''
    display_options:
      access:
        type: perm
      cache:
        type: none
      query:
        type: views_query
      exposed_form:
        type: basic
      pager:
        type: full
        options:
          items_per_page: '10'
      style:
        type: default
      row:
        type: node
        options:
          build_mode: teaser
          links: '1'
          comments: '0'
      fields:
        title:
          id: title
          table: node
          field: title
          label: ''
          alter:
            alter_text: '0'
            make_link: '0'
            absolute: '0'
            trim: '0'
            word_boundary: '0'
            ellipsis: '0'
            strip_tags: '0'
            html: '0'
          hide_empty: '0'
          empty_zero: '0'
          link_to_node: '1'
      filters:
        status:
          value: '1'
          table: node
          field: status
          id: status
          expose:
            operator: '0'
          group: '1'
      sorts:
        created:
          id: created
          table: node
          field: created
          order: DESC
      title: Test
  page_1:
    display_plugin: page
    id: page_1
    display_title: Page
    position: ''
    display_options:
      path: test
human_name: Test
module: views
id: test
tag: ''
uuid: f862704e-d9e8-4f33-9f00-fe8a13977e77
langcode: en

This looks RTBC to me.

In general it seems to be that we want to move the entity ID to the top as well, but sure this is out of the scope of this issue.

Agreed.

follow-up for #16 and #44: #1938570: Make views active config save format match the default yml file (order and quotes)

follow-up for #21 #1938576: Tags and Language setting not discoverable under "edit view name/description" button

I'll add to the summary.

added follow-up section and issues

Awesome!!

Committed and pushed to 8.x. Thanks!

I really think we should show the language select menu and the tag field on the view create form. I don't buy the reasoning behind the explanation in #21. What used to be an easy thing to do in D7 requires at least two extra clicks in D8 and is hidden behind a button that doesn't provide any hint these settings can be configured there.

I really think we should show the language select menu and the tag field on the view create form. I don't buy the reasoning behind the explanation in #21. What used to be an easy thing to do in D7 requires at least two extra clicks in D8 and is hidden behind a button that doesn't provide any hint these settings can be configured there.

I understand that there might be use-cases in which you want to configure a lot of different views in different languages, but even for a multilingual page I think using the site default language will work in most cases. Additional your point that this was easier in D7 feels wrong. At least I don't know of a place on the add views formular where you can configure the language?

...the "easy thing in D7" was meant for the views tag only.

Oh you talk about D6. In general I don't think that having a tag exposed primarily helps anyone.