Dear Sir:
I just installed Drupal8 dev and found that my language name "Uyghur" is in in Cyrillic alphabet as "Уйгур".

Could you review it and change it to "Uyghur" in Latin alphabet or "ئۇيغۇرچە", in Uyghur alphabet?
Thank you very much.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xmacinfo’s picture

Assigned: Emin Sulaiman » Unassigned

@Emin Sulaiman: You should assign this to you only if you are currently working on this. For example, by creating the patch.

Emin Sulaiman’s picture

Issue summary: View changes
FileSize
21.77 KB
Emin Sulaiman’s picture

Is possible to change this Cyrillic term as "Уйгур" to "Uyghur" in Latin alphabet or "ئۇيغۇرچە", in Uyghur alphabet?
Thank you very much.

longwave’s picture

FileSize
848 bytes

Please apply the attached patch. The Uyghur language should be displayed in the Uyghur alphabet.

alansaviolobo’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
30.15 KB

after applying the patch the dropdown shows the value as described.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: 1926000-uyghur-language-name.patch, failed testing.

alansaviolobo’s picture

Status: Needs work » Needs review
FileSize
857 bytes

rerolling

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Emin Sulaiman’s picture

Assigned: Unassigned » Emin Sulaiman

change Уйғур to ئۇيغۇرچە

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jungle’s picture

Assigned: Emin Sulaiman » Unassigned
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
56.79 KB

Manual tested #7, It works fine.

#9 already done by #7.

+++ b/core/lib/Drupal/Core/Language/LanguageManager.php
@@ -342,7 +342,7 @@ public static function getStandardLanguageList() {
-      'ug' => array('Uyghur', 'Уйғур'),
+      'ug' => array('Uyghur', /* Left-to-right marker "‭" */ 'ئۇيغۇرچە', Language::DIRECTION_RTL),

The Uyghur is a RTL language. #7 not only fixed what this issue addressed, but also fixed the RTL part of the Uyghur language additionally.

jungle’s picture

One more thing, the string ئۇيغۇرچە displayed here in plain text and in code highlight looks different. Actually, they are same string. The truth is that they use different font-family in CSS.

jungle’s picture

Issue summary: View changes

Remove unintentional changes to summary at #11.

alexpott’s picture

Title: Drupal8 dev: language name Uyghur in Cyrillic alphabet » Language name Uyghur in Cyrillic alphabet

Discussed with @GaborHojtsy and we agreed that this change is correct because it is the writing system used in the current the translation on l.d.o. Additionally it matches the language name given in https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

As this is just a string change making in 8.3.x. I think there is a case to say this is a bug because the writing system does not match the system used on l.d.o and therefore this could be ported to 8.2.x but I'd like other +1's before I do that. This is not a translatable string change as these strings are not passed through t() by design.

diff --git a/core/lib/Drupal/Core/Language/LanguageManager.php b/core/lib/Drupal/Core/Language/LanguageManager.php
index d636823..ef54217 100644
--- a/core/lib/Drupal/Core/Language/LanguageManager.php
+++ b/core/lib/Drupal/Core/Language/LanguageManager.php
@@ -318,7 +318,7 @@ public static function getStandardLanguageList() {
       'th' => array('Thai', 'ภาษาไทย'),
       'tr' => array('Turkish', 'Türkçe'),
       'tyv' => array('Tuvan', 'Тыва дыл'),
-      'ug' => array('Uyghur', /* Left-to-right marker "‭" */ 'ئۇيغۇرچە', Language::DIRECTION_RTL),
+      'ug' => array('Uyghur', /* Left-to-right marker "‭" */ 'ئۇيغۇرچە', LanguageInterface::DIRECTION_RTL),
       'uk' => array('Ukrainian', 'Українська'),
       'ur' => array('Urdu', /* Left-to-right marker "‭" */ 'اردو', LanguageInterface::DIRECTION_RTL),
       'vi' => array('Vietnamese', 'Tiếng Việt'),

Fixed to use LanguageInterface constant on commit.

alexpott’s picture

Committed 7313770 and pushed to 8.3.x. Thanks!

  • alexpott committed 7313770 on 8.3.x
    Issue #1926000 by alansaviolobo, longwave, Emin Sulaiman, jungle:...
xmacinfo’s picture

I really do think that this is OK to push to 8.2.x:

  • It solves a display bug.
  • It matches l.d.o.

Do we need to set to RTBC back?

alexpott’s picture

@xmacinfo yeah @GaborHojtsy agreed with you... so I'll just cherry pick this...

Committed d2332c0 and pushed to 8.2.x. Thanks!

  • alexpott committed d2332c0 on 8.2.x
    Issue #1926000 by alansaviolobo, longwave, Emin Sulaiman, jungle:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.