Some of the styling in overlay-child.css is affecting the label within the Overlay listing on the Extend page. This is because the label has an id of 'overlay'.

I'm not sure if this is a fix for the Overlay module because I'm not sure why we are printing module id's on the labels in the first place. If it's for the performance of Javascript filtering then a data attribute seems more appropriate.

Screen Shot 2013-02-17 at 15.49.56.png

CommentFileSizeAuthor
#7 overlay-1919564-7.patch1.29 KBrajneeshb
#3 Screen Shot 2013-02-17 at 18.31.55.png17.65 KBLewisNyman
#2 drupal8.system-modules-id.2.patch898 bytessun
Screen Shot 2013-02-17 at 15.49.56.png59.83 KBLewisNyman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Component: overlay.module » system.module

That #id is not used by the module list search/filter.

I quickly checked the code, but it looks like it gets auto-generated by Form API. But then again, such IDs should normally be "edit-foo", not just "foo".

Something is completely wrong there.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Active » Needs review
FileSize
drupal8.system-modules-id.2.patch898 bytes

Gotcha.

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Status: Needs review » Reviewed & tested by the community
FileSize
Screen Shot 2013-02-17 at 18.31.55.png17.65 KB

Patch applies cleanly, everything is look great.

Screen Shot 2013-02-17 at 18.31.55.png

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Reviewed & tested by the community » Needs review

These IDs were added intentionally in #1828464: Add same-page links to the Module page, so this needs to at least mention why it is OK to revert that instead of changing the IDs to fix the bug.

EDIT: That was BS, sorry...

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Reviewed & tested by the community

Reverting status

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice

That's a pretty hilarious bug. :)

However, it totally undoes #184010: Add #anchors to modules administration page which was done for a reason, so I think the better fix is to preface with module- which is what earlier versions of that patch did.

That should be pretty easy to do, so tagging Novice.

rajneeshb’s picture

rajneeshb CreditAttribution: rajneeshb commented
Component: system.module » overlay.module
Status: Needs work » Needs review
FileSize
overlay-1919564-7.patch1.29 KB

I have checked and found that there are two ID named as "overlay" . so I created a patch for overlay module to remove duplicate overlay ID.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented

I guess we could actually do both, (i.e. change overlay module to use #overlay-wrapper and the modules page to use #module-$module), but this doesn't hurt either.

bleen’s picture

bleen CreditAttribution: bleen commented
Status: Needs review » Reviewed & tested by the community

Personally I like the solution in #7 better than prefacing the module class with "module-" and I dont see any reason why we need to do both.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Reviewed & tested by the community » Closed (duplicate)

I disagree with the proposed solution.

The bug is that System module violates the CSS namespaces of other modules.

To wit: User module uses #module-[name] CSS IDs on the Permissions page.

This needs to be fixed in the original issue. Marking as duplicate of #184010: Add #anchors to modules administration page