This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for simpletest module.

Schema in place

Schema not yet in place
simpletest.settings.yml

CommentFileSizeAuthor
#1 1919200-simpletest-schema-1.patch625 bytesvijaycs85
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Active » Needs review
FileSize
1919200-simpletest-schema-1.patch625 bytes

Adding schema file...

Status: Needs review » Needs work
Issue tags: -Configuration system, -D8MI, -language-config, -Configuration schema

The last submitted patch, 1919200-simpletest-schema-1.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Status: Needs work » Needs review
Issue tags: +Configuration system, +D8MI, +language-config, +Configuration schema

#1: 1919200-simpletest-schema-1.patch queued for re-testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

I'd like to mark this won't fix for two reasons:

  1. There's nothing in these settings that needs a schema; i.e., no translatable string, nothing that could vary by context, or anything the like.
  2. Simpletest is a pure developer module to begin with.

That said, I believe that 1) should be applied as rule of thumb to all modules, regardless of 2). Config schema files should be optional.

Status: Needs review » Needs work

The last submitted patch, 1919200-simpletest-schema-1.patch, failed testing.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs work » Closed (won't fix)

Right, I agree config schemas are not required. I don't think we fully explored the use cases for which they will be useful, but this module is not in the immediate use case that we introduced schemas for. I think its fine to mark this won't fix and others who might have use cases can come in and provide those still.