This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.
Problem/motivation
#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.
Proposed solution
Create a configuration schema for shortcut module.
Schema in place
Schema not yet in place
shortcut.set.default.yml
Comment | File | Size | Author |
---|---|---|---|
#9 | schema_patch_8.PNG | 24.14 KB | rahuldolas123 |
#8 | 1919198-shortcut-schema-8.patch | 512 bytes | rachit_gupta |
#7 | 1919198-shortcut-schema-7.patch | 450 bytes | vijaycs85 |
#7 | 1919198-diff-1-7.txt | 507 bytes | vijaycs85 |
#1 | 1919198-shortcut-schema-1.patch | 408 bytes | vijaycs85 |
Comments
Comment #1
vijaycs85Adding schema file...
Comment #3
vijaycs85#1: 1919198-shortcut-schema-1.patch queued for re-testing.
Comment #5
vijaycs85Random errors.. re-testing again..
Comment #6
vijaycs85#1: 1919198-shortcut-schema-1.patch queued for re-testing.
Comment #7
vijaycs85Updating labels...
Comment #8
rachit_gupta CreditAttribution: rachit_gupta commentedUpdating according to codestyle at http://drupal.org/node/1905070#codestyle
Comment #9
rahuldolas123 CreditAttribution: rahuldolas123 commentedHello,
I have tested the above patch with config inspector module and the patch works.
Attaching the screenshot for the same.
Comment #10
vijaycs85Thanks @rahuldolas123. It looks fine to me too.
Comment #11
webchickCommitted and pushed to 8.x. Thanks!
Although...
ID is not a mere "string", it is in fact a machine name, and probably ought not to be trifled with (or at the very least ought to have machine name validation). Do we track that as a separate type? If not, should we?
Comment #12
webchick