common_test.module - Convert theme_ functions to Twig

Here's a rough one:)

Removed the unnecessary template_preprocess and added some white space modifiers to help it pass the simpletests.

Nice! The only thing I see is we should remove the unnecessary preprocess from the Twig file's docblock too.

Good call.

Removed the front whitespace modifier because @steveoliver suggested it is unnessasry and the twig docs mention the newline after the docblock is removed automatically.

http://twig.sensiolabs.org/doc/templates.html#whitespace-control

Crosses fingers.

It seems like our tests should be ignore whitespace that shows up when checking against stuff - rather than the *exact string. But thats a whole other discussion..

The patch from #8 looks good to me. Always glad to see where we can drop a theme/preprocess altogether. I have heard some various opinions in irc on the whitespace control for these conversions, but I personally am okay with it. Especially if whitespace is the only thing keeping the test from passing.

#8: drupal-twig-common_test-1898456-8.patch queued for re-testing.

RTBC if it comes back green. Good work @joelpittet :)

Add conversion summary table

#8: drupal-twig-common_test-1898456-8.patch queued for re-testing.

About to re-roll

#8: drupal-twig-common_test-1898456-8.patch queued for re-testing.

Running profile on drupal-twig-common_test-1898456-8.patch

=== 8.x..8.x compared (519fff4bc13bf..519fffaed3821):

ct : 610,847|610,847|0|0.0%
wt : 5,733,916|5,732,281|-1,635|-0.0%
cpu : 5,638,489|5,631,327|-7,162|-0.1%
mu : 58,147,712|58,147,712|0|0.0%
pmu : 58,361,520|58,361,520|0|0.0%

=== 8.x..issue-1898456 compared (519fff4bc13bf..519fffcb3a4b0):

ct : 610,847|610,847|0|0.0%
wt : 5,733,916|5,788,314|54,398|0.9%
cpu : 5,638,489|5,684,892|46,403|0.8%
mu : 58,147,712|58,149,264|1,552|0.0%
pmu : 58,361,520|58,362,504|984|0.0%

#8: drupal-twig-common_test-1898456-8.patch queued for re-testing.

@rwohleb could you post your scenario in the summary for testing so someone can try to reproduce your results? Also, thanks for doing those! They don't look all that bad coming from a theme to template conversion.

Looks like same number of function calls in the 8.x..issue-1898456 comparison. I'll redo this one.

I couldn't figure out how to hit the template.

I'm going to go ahead and say we don't need profiling on this because it's only used for automated testing, and set back to RTBC. Thanks for your efforts everyone :)

#8: drupal-twig-common_test-1898456-8.patch queued for re-testing.

Committed c5cecfd and pushed to 8.x. Thanks!