Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a follow-up issue from #1497380: Convert shortcut sets to ConfigEntity
There's some code that needs some polish and optimization
Comments
Comment #1
Wim LeersThis is the only thing I think that's left. The
label()
method is necessary when uninstalling the Shortcut module, so that the shortcut set config entities that will be deleted can list their proper names.Comment #2
illutek CreditAttribution: illutek commentedGo here to take a try
Comment #3
michaelfavia CreditAttribution: michaelfavia commentedCould be way off base here but I tested an uninstall on a custom shortcut set and it didn't seem to need the label() method to properly output the shortcut name. Perhaps it is inherited from Entity::label() via ConfigEntity? Please don't hesitate to reopen if I'm missing the point. Just getting my feet wet in D8 again.
Comment #4
andypostThere's some clean-up tasks left to move and deprecate procedural code wrappers to entity methods, but all of them unrelated to subject