The following tests will throw exceptions if multiple db slave servers are configured in settings.php

  • SELECT TESTS, COMPLEX 2
  • PAGER QUERY
  • TABLESORT QUERY

The reason is that the initial prefix handling during test, does not respect the $databases structure.

Patch coming up ...

CommentFileSizeAuthor
#3 1893996-3-simpletest-prefix.patch1.87 KBgielfeldt
#1 1893996-1-simpletest-prefix.patch1.84 KBgielfeldt

Comments

gielfeldt’s picture

gielfeldt commented
StatusFileSize
new 1893996-1-simpletest-prefix.patch1.84 KB
gielfeldt’s picture

gielfeldt commented
Status: Active » Needs review
gielfeldt’s picture

gielfeldt commented
Version: 7.x-dev » 8.x-dev
StatusFileSize
new 1893996-3-simpletest-prefix.patch1.87 KB

D8 patch

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Needs tests

This actually needs test coverage

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Needs work

agree with @andypost
#3 looks good anyway

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes

Should be committed even without tests. To test this you'd probably need the autoslave module. So therefore the tests should be done in contrib, not core. Core already has enough tests to make sure that this doesn't cause a regression. Unless of course there was some way to synthesize a test without autoslave?

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Needs work

In order to write a test for this you'd have to add a test configuration for master/slave or master/master/slave or master/slave/slave , which normally would require the autoslave module as core does not currently support this type of configuration on it's own.

However, perhaps a pseudo test could be written in the test sandbox where the expected configuration for a slave would be appended to the database array prior to an assert? I suppose it is could be possible to write this sort of test! any volunteers?

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dsutter’s picture

dsutter commented

RTBC+ patch #1 for D7

gdaw’s picture

gdaw commented

Patch #1 RTBC +1

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed (maintainer needs more info)

Issue appears to be 5+ years old. The function in question _drupal_initialize_db_test_prefix is no longer part of Drupal 9 (currently on 9.5.x). Could someone confirm this issue still? If so adding updated summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@smustgrave, the Drupal 9 development of autoslave, the module that uses this patch is maintained by the Ukrainian developer eugene.brit , he may be able to answer your questions.

#3259794: D9 stable version

smustgrave’s picture

smustgrave commented

I don't see this ticket listed on that page?

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#2363315: Refactor Database:: static properties and methods
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@smultgrave, it appears that the D9 version of autoslave does not require a core patch. With that said , currently only 5 Drupal 9 installations are using autoslave whereas approximately 185 installations are Drupal 7 installations that use the Drupal 7 version of this patch. I haven't tried autoslave with Drupal 9, it's quite an advanced db setup and configuration required to be able use this.

With that said, I did development on the autoslave module back in 2017 and it is impressive to see in action when it's set up correctly.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: +Bug Smash Initiative

Tagging for the Bug Smash Initiative.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

pameeela’s picture

pameeela commented
Version: 11.x-dev » 7.x-dev
Status: Postponed (maintainer needs more info) » Needs work

Knocking this back to D7 since it was confirmed it's not an issue in D9.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.