PHP warning/notice when disabling and uninstalling modules [#1887136]

Updated as of #24.

Problem/Motivation

After uninstalling the locale_tamper module (or any other module) and revisiting admin/reports/translations the following notices are displayed:

Notice: Undefined index: locale_tamper in locale_translation_status_form() (line 634 of core/modules/locale/locale.pages.inc).
Notice: Trying to get property of non-object in locale_translation_status_form() (line 634 of core/modules/locale/locale.pages.inc).
Notice: Undefined index: echo in locale_translation_status_form() (line 634 of core/modules/locale/locale.pages.inc).
Notice: Trying to get property of non-object in locale_translation_status_form() (line 634 of core/modules/locale/locale.pages.inc).

When uninstalling a module before any translation is imported the below warning is displayed. Although this is an edge use case, the fix is easy.

Warning: Invalid argument supplied for foreach() in locale_translation_status_delete_projects() (line 985 of core/modules/locale/locale.module).

Proposed resolution

Check if there are any status's (it is not empty) before changing status and resaving it.

Remaining tasks

reproduce on current d8 head.

Steps to reproduce

based on #9

install d8
"install/extend" (not called enable) interface translation module under Extend
add a language at admin/config/regional/language
download a module, for example UI Cache Clear, https://drupal.org/node/1969588/git-instructions/8.x-1.x
Add a line to the ui_cache_clear.info.yml file: project: "ui_cache_clear" (the packaging script does not yet work with D8 .info.yml files, we need this for it to know how to try and fetch the translation file for the project)
install the module, on Extend, admin/modules

go to admin/reports/translations, and see

    Home >>    Administration >>    Reports

Available translation updates
Add or remove shortcut

Last checked: never (Check manually)
	Language	Status
	Afrikaans	Hide description Missing translations for 2 projects

    Drupal core (8.0-dev). No translation files are provided for development releases.
    UI Cache Clear (no version). File not found at http://ftp.drupal.org/files/translations/8.x/ui_cache_clear/ui_cache_clear-.af.po nor at translations://ui_cache_clear-.af.po

check for translations manually on admin/reports/translations
uninstall a module, on admin/modules/uninstall, for example: Contact
reload the translations report page admin/reports/translations
See error? Or no error? How many projects does it say it is missing translations for? Did it reduce from 2 to 1?)

User interface changes

none

API changes

none

Related Issues

Originally this issue was about disabling, now it is about uninstall due to: #1199946: Disabled modules are broken beyond repair so the "disable" functionality needs to be removed

Original Report (before disabling was removed)

After disabling a the locale_tamper module (or any other module) and revisiting admin/reports/translations the following notices are displayed:

Notice: Undefined index: locale_tamper in locale_translation_status_form() (line 634 of core/modules/locale/locale.pages.inc).
Notice: Trying to get property of non-object in locale_translation_status_form() (line 634 of core/modules/locale/locale.pages.inc).
Notice: Undefined index: echo in locale_translation_status_form() (line 634 of core/modules/locale/locale.pages.inc).
Notice: Trying to get property of non-object in locale_translation_status_form() (line 634 of core/modules/locale/locale.pages.inc).

When uninstalling a module before any translation is imported the below warning is displayed. Although this is an edge use case, the fix is easy.

Warning: Invalid argument supplied for foreach() in locale_translation_status_delete_projects() (line 985 of core/modules/locale/locale.module).

Comment	File	Size	Author
#27	Language4.png	110.72 KB	oheller
#27	Language2.png	132.34 KB	oheller
#25	Available translation updates localhost.png	46.17 KB	Prashant.c
#25	Extend localhost.png	49.94 KB	Prashant.c
#23	updatingtranslations.png	89 KB	YesCT
#20	locale-notice-disable-module-1887136-20.patch	842 bytes	jlbellido
#20
#20	interdiff.txt	611 bytes	jlbellido
#16	locale-notice-disable-module-1887136-16.patch	1.23 KB	jlbellido
#16
#16	interdiff-1887136.txt	578 bytes	jlbellido
#13	locale-notice-disable-module-1887136-13.patch	1.23 KB	jlbellido
#13
#4	warning_1887136.jpg	34.14 KB	docker
#1	locale-notice-disable-module-1887136-1.patch	1.31 KB	Sutharsan
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Sutharsan CreditAttribution: Sutharsan commented 12 January 2013 at 21:43

Status:	Active	» Needs review
Issue tags:		+D8MI, +language-ui

File	Size
locale-notice-disable-module-1887136-1.patch	1.31 KB

The attached patch implements hook_modules_disabled() to clear the translation status when a module is disabled. This solved the php notice.
For the php warning is adds an if-condition to locale_translation_status_delete_projects() to check for existing translation status before it is removed.

Comment #2

Sutharsan CreditAttribution: Sutharsan commented 12 January 2013 at 21:43

Comment #3

YesCT CreditAttribution: YesCT commented 17 January 2013 at 09:43

Issue tags:

+Novice, +Needs manual testing

tagging

Comment #4

docker CreditAttribution: docker commented 2 February 2013 at 15:35

File	Size
warning_1887136.jpg	34.14 KB

After the first time disabling the locale_tamper get the attached warning on the modules page.
I didn't get any message on the admin/reports/translations page.
After that I couldn't reproduce the error even If I tried to uninstall a different module or uninstall-install-disable the locale_tamper.

After a new d8 installation I've applied the #1 patch. I didn't get the warning or any other message after the first time disabling the locale_tamper. I still havent got any message after uninstalling the module.

Comment #5

Elijah Lynn

Portland, Oregon

CreditAttribution: Elijah Lynn commented 3 February 2013 at 20:50

Status:

Needs review

» Needs work

Just checkout latest 8.x-dev and cannot reproduce either. Can you see if latest HEAD still has this issue?

Comment #6

stpaultim CreditAttribution: stpaultim commented 2 April 2013 at 05:13

Trying to recreate this issue. So far unsuccessful. Posting my steps so folks can help see if I'm missing anything:

NOTE: I was unable to try this with the "locale_tamper" module as suggested, because the "locale_tamper" module does not have .info.yml files and will not load.

1) Pulled a fresh version of Drupal 8 with GIT
2) Turn on Multilingual modules: Content Translation, Interface Translation, & Language
• Without these modules, there is no "translation" report. Even with them, it's an "Available Translation Updates" report.
3) Install Devel module
• Get AJAX HTTP error ("An AJAX HTTP error occurred. HTTP Result Code: 200 Debugging information follows. Path: http://drupal8:8082 ................) I am ignoring this for now, because I seem to get this error for every module I install. See: #1885788: An AJAX HTTP error occurred during module installation via UI
• Enable Devel module
4) In "Devel Settings" toggle "Display query log" - and verify that query log is working. Toggle it off again. (Just wanted to actually DO something with Devel before disabling it.
5) Disable Devel module and uninstall Devel module
• Go to Reports >> Available Translation Updates and look for error. None found.
6) Under "Available Translation Updates" Add 3 languages (German, French, & Amharic).
7) Install Backup and Migrate Module.
• Get AJAX HTTP error ("An AJAX HTTP error occurred. HTTP Result Code: 200 Debugging information follows. Path: http://drupal8:8082 ................) I am ignoring this for now, because I seem to get this error for every module I install. See: #1885788: An AJAX HTTP error occurred during module installation via UI
• Enable Backup and Migrate module
8) Create a QUICK BACKUP using Backup and Migrate Module - again, to actually do something with the module before disabling it.
9) Disable Backup and Migrate module.
• Go to Reports >> Available Translation Updates and look for error. None found.
10) Uninstall Backup and Migrate module.
• Go to Reports >> Available Translation Updates and look for error. None found.

=================

If anyone can suggest anything else I might do that would create this problem, let me know and I'll try again. ALSO: the reports suggested the problem occurred when "revisiting admin/reports/translations." I'm not exactly sure which report this is. I tried to recreate the error looking at the "Available translation updates" report. If I'm misunderstanding the problem, please correct me and I'll try again.

Comment #7

YesCT CreditAttribution: YesCT commented 2 April 2013 at 05:26

@stpaultim is the behavior any different if you go to the translations status report while the module is on, *then* disable it and go back to the report?

Comment #8

robertdbailey CreditAttribution: robertdbailey commented 24 May 2013 at 17:06

Status:

Needs work

» Closed (cannot reproduce)

@YesCT, confirmed no difference if we first visit the translation status report while the module is on and then disable the module and go back to the report. I visited the report, then enabled the XML-RPC module, then visited the report again to confirm there were no warning messages, then disabled the XML-RPC module, then visited the report again to confirm there were again no warning messages.

So, I am not able to reproduce the error, along with @Elijah Lynn and @stpaultim. Closing issue as cannot reproduce.

Comment #9

Sutharsan CreditAttribution: Sutharsan commented 24 May 2013 at 20:06

Status:

Closed (cannot reproduce)

» Needs review

I can still repoduce the error, and this is how:

Install Drupal: English, Standard profile, MySQL database
Enable Language + Interface translation module
Enable a language: Dutch
Download a module: UI Cache Clear
Add a line to the ui_cache_clear.info.yml file: project: "ui_cache_clear" (the packaging script does not yet work with D8 .info.yml files)
Enable the module: admin/modules
Go to Available translation updates page: admin/reports/translations
Disable the module: admin/modules
Go to Available translation updates page: admin/reports/translations
Now you see the error:

Notice: Undefined index: ui_cache_clear in locale_translation_status_form() (line 513 of core/modules/locale/locale.pages.inc).
Notice: Trying to get property of non-object in locale_translation_status_form() (line 513 of core/modules/locale/locale.pages.inc).

Comment #10

nonsie

she/her

Estonian

CreditAttribution: nonsie commented 24 May 2013 at 21:45

Followed the steps but was unable to replicate this error

Comment #11

andymartha CreditAttribution: andymartha commented 12 August 2013 at 21:07

Followed the steps in #9 but was unable to replicate this error

Comment #12

jair CreditAttribution: jair commented 17 August 2013 at 19:10

Issue tags:

+Needs reroll

Needs Reroll

Comment #13

jlbellido

Spanish

CreditAttribution: jlbellido commented 21 September 2013 at 11:13

File	Size
locale-notice-disable-module-1887136-13.patch	1.23 KB

Rerolled with @luismagr and @neoligero , and run test.

Comment #14

21 September 2013 at 12:57

Status:

Needs review

» Needs work

The last submitted patch, locale-notice-disable-module-1887136-13.patch, failed testing.

Comment #15

Sutharsan CreditAttribution: Sutharsan commented 21 September 2013 at 13:32

+++ b/core/modules/locale/locale.module
@@ -1084,13 +1093,14 @@ function locale_translation_status_delete_languages($langcodes) {
 function locale_translation_status_delete_projects($projects) {
   $status = locale_translation_get_status();
-
-  foreach ($status as $project => $languages) {
-    if (in_array($project, $projects)) {
-      unset($status[$project]);
+  if (isset($status)) {
+    foreach ($status as $project => $languages) {
+      if (in_array($project, $projects)) {
+        unset($status[$project]);
+      }
     }
+    \Drupal::state()->set('locale.translation_status', $status);
   }
-  \Drupal::state()->set('locale.translation_status', $status);
 }

The if (isset($status)) condition will always be true. In worst case locale_translation_get_status() will return an empty array. Should be if (!empty($status)).

Comment #16

jlbellido

Spanish

CreditAttribution: jlbellido commented 21 September 2013 at 15:52

Status:

Needs work

» Needs review

File	Size
interdiff-1887136.txt	578 bytes
locale-notice-disable-module-1887136-16.patch	1.23 KB

Thanks @Shutharsan, sorry for that.

Comment #17

21 September 2013 at 17:22

Status:

Needs review

» Needs work

The last submitted patch, locale-notice-disable-module-1887136-16.patch, failed testing.

Comment #18

mr.baileys

Dutch

🇧🇪 (Ghent)

CreditAttribution: mr.baileys commented 23 September 2013 at 11:07

Status:	Needs work	» Reviewed & tested by the community
Issue tags:	-Novice, -Needs manual testing, -Needs reroll

Confirmed the bug using the steps from #9
Manually tested and confirmed the patch from #16 fixed the issues.

The failing test seems unrelated to this patch, and passes locally, so setting to RTBC.

Comment #19

mr.baileys

Dutch

🇧🇪 (Ghent)

CreditAttribution: mr.baileys commented 23 September 2013 at 11:07

#16: locale-notice-disable-module-1887136-16.patch queued for re-testing.

Comment #20

jlbellido

Spanish

CreditAttribution: jlbellido commented 23 September 2013 at 20:20

Status:

Reviewed & tested by the community

» Needs review

File	Size
interdiff.txt	611 bytes
locale-notice-disable-module-1887136-20.patch	842 bytes

Deleted hook_modules_disabled() because now modules can't be disabled. Thanks @Sutharsan for to advise me.

Comment #21

penyaskito

he/him

Spanish

🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺

CreditAttribution: penyaskito commented 24 September 2013 at 13:21

Status:

Needs review

» Reviewed & tested by the community

Back to RTBC after Sutharsan requirement were fixed.

Comment #21.0

YesCT CreditAttribution: YesCT commented 29 September 2013 at 09:49

Issue summary:

View changes

in progress updating due to disabling modules broken...

Comment #22

YesCT CreditAttribution: YesCT commented 29 September 2013 at 09:56

Issue tags:

+Needs issue summary update

I'm updating the issue summary.

Comment #22.0

YesCT CreditAttribution: YesCT commented 29 September 2013 at 09:56

Issue summary:

View changes

fix typo and clarify

Comment #23

YesCT CreditAttribution: YesCT commented 29 September 2013 at 11:21

Status:	Reviewed & tested by the community	» Needs review
Issue tags:		+Needs manual testing

File	Size
updatingtranslations.png	89 KB

I cannot reproduce this.

I did notice a few things while trying to, these should be separate issues if they are not already:
1. #2034879-3: [Meta] Fix documentation that refers to enabling/disabling of modules
admin/config/regional/translate/settings
says "Check for updates of disabled modules and themes"

2. Even when my settings admin/config/regional/translate/settings says

Check for updates:
 never (manually)

When I install a module, I get a batch progress bar that says

I did not expect it to get the translation. I have configured to never get updates.
2a. is it really checking for the translation?
2b. is getting the initial translation different than checking for updates?

3. When installing, I get notice:
Notice: Undefined index: path in Drupal\Core\Routing\RouteBuilder->rebuild() (line 97 of core/lib/Drupal/Core/Routing/RouteBuilder.php).
Maybe because the locale module is doing something related to translating config.

Comment #23.0

YesCT CreditAttribution: YesCT commented 29 September 2013 at 11:21

Issue summary:

View changes

added steps to reproduce

Comment #24

YesCT CreditAttribution: YesCT commented 29 September 2013 at 11:32

Issue tags:

-Needs issue summary update

up to date summary for now.
But need someone to verify this is reproducible.

Comment #24.0

YesCT CreditAttribution: YesCT commented 29 September 2013 at 11:32

Issue summary:

View changes

updated approach.

Comment #24.1

YesCT CreditAttribution: YesCT commented 29 September 2013 at 11:33

Issue summary:

View changes

noting up to date as of... comment number

Comment #25

Prashant.c

he/him

English

Dharamshala

CreditAttribution: Prashant.c commented 16 November 2013 at 07:04

Issue summary:

View changes

File	Size
Extend localhost.png	49.94 KB
Available translation updates localhost.png	46.17 KB

Followed the steps by #9 and able to reproduce this error.
Also getting warnings after enabling the module ui_cache_clear attaching screenshots.

Comment #26

Prashant.c

he/him

English

Dharamshala

CreditAttribution: Prashant.c commented 16 November 2013 at 07:08

Status:

Needs review

» Needs work

Comment #27

oheller CreditAttribution: oheller commented 6 July 2014 at 22:30

File	Size
Language2.png	132.34 KB
Language4.png	110.72 KB

While trying to recreate #9 I had the below issues. Here is the process I made it through.

1) Install Drupal: English, Standard profile, MySQL database
2) Enable Language + Interface translation module
3) Enable a language: Dutch
4) Download a module: UI Cache Clear
5) Add a line to the ui_cache_clear.info.yml file: project: "ui_cache_clear" (the packaging script does not yet work with D8 .info.yml files)
6) Enable the module: admin/modules - Error Language2

7) Install and enable Rules module.
8) Uninstall Rules module (wanted to add project:"rules" to rules.info.yml) - Error Language4

I haven't been able to reproduce this yet.

Comment #28

6 July 2014 at 22:30

Version:

8.0.x-dev

» 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #29

6 July 2014 at 22:30

Version:

8.1.x-dev

» 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #30

6 July 2014 at 22:30

Version:

8.2.x-dev

» 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #31

6 July 2014 at 22:30

Version:

8.3.x-dev

» 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #32

6 July 2014 at 22:30

Version:

8.4.x-dev

» 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #33

6 July 2014 at 22:30

Version:

8.5.x-dev

» 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #34

6 July 2014 at 22:30

Version:

8.6.x-dev

» 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #35

6 July 2014 at 22:30

Version:

8.8.x-dev

» 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Comment #36

g-brodiei

Chinese, Traditional

CreditAttribution: g-brodiei as a volunteer commented 14 July 2020 at 14:31

Status:	Needs work	» Closed (cannot reproduce)
Issue tags:	-Needs manual testing	+Bug Smash Initiative

As part of Bush Smash Initiative,

I'm trying to reproduce the bug following instructions on the issue summary updated by @YesCT and #9. I'd also tried the steps on #27 by @oheller. Big thanks to all previous contributors providing tests and patches.

Do note that adding new line to {module_name}.info.yml file as mentioned on Step 5 of IS is not tested since the packing script of drupal.org adds this automatically already.

I did the following steps,

1. Fresh install 8.9.x, php 7.3, mysql 5.7
2. Enable interface translation module (locale)
3. Add new language Chinese, Traditional at admin/config/regional/language
3. Install taxonomy menu module with composer require drupal/taxonomy_menu
4. Check admin/reports/translations, no errors were shown
5. Uninstall taxonomy menu module
6. Check admin/reports/translations, no errors were shown again
7. Tried with new language Afrikaans, and repeat step 4-6.

Still no error or bug shown like issue description.

Therefore, I'm closing this issue as it cannot be reproduced.