Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
When installing a module via the UI, it looks like a whole HTML page is being returned at some point instead of just a JSON response. The actual error was on the next page:
User error: "data" is an invalid render array key in element_children() (line 6009 of core/includes/common.inc).
Proposed resolution
pass the message in an array with the #markup key.
Remaining tasks
- (done in #13) Patch needs to be reviewed.
User interface changes
None.
API changes
None.
Related Issues
Original report by jenlampton
Comment | File | Size | Author |
---|---|---|---|
#12 | drupal-1885788-12.patch | 795 bytes | alimac |
#2 | drupal-1885788-2.patch | 773 bytes | tim.plunkett |
Comments
Comment #1
jenlamptonNevermind, it looks like this is a core issue. Not related to our sandbox :)
Comment #1.0
jenlamptonadd more words
Comment #2
tim.plunkettThe actual error was on the next page:
User error: "data" is an invalid render array key in element_children() (line 6009 of core/includes/common.inc).
Comment #3
dcam CreditAttribution: dcam commentedhttp://drupal.org/node/1427826 contains instructions for updating the issue summary with the summary template.
The summary may need to be updated with information from comments.
Comment #4
alimac CreditAttribution: alimac commentedI'm going to work on updating the issue summary.
Comment #4.0
alimac CreditAttribution: alimac commentedupdate to match core instad of sandbox
Comment #5
alimac CreditAttribution: alimac commentedUpdated issue summary.
Comment #5.0
alimac CreditAttribution: alimac commentedUpdated issue summary to use template.
Comment #5.1
YesCT CreditAttribution: YesCT commentedadded related, maybe duplicate
Comment #6
valthebaldTagging
Comment #7
mgifford2: drupal-1885788-2.patch queued for re-testing.
Comment #8
YesCT CreditAttribution: YesCT commentedComment #9
Anonymous (not verified) CreditAttribution: Anonymous commentedI've tried to reproduce the issue, but wasn't able to. It's likely that this is no longer relevant.
There is no need for a reroll, since the patch still applies.
The issue marked as related is about an out of memory exception, whereas this is about an issue while rendering. I don't think they are related.
Comment #11
jhedstromPatch no longer applies. From what I can tell this will still be an issue:
Since a string is still being passed into the
data
item, rather than an array as the patch above does.Comment #12
alimac CreditAttribution: alimac commentedI re-rolled the patch (per instructions: https://www.drupal.org/patch/reroll) and verified that it applies cleanly to HEAD.
Comment #13
jhedstromThis is still an issue,
Element::children()
still throws an error on this render array as it is returned now. The patch fixes the error.Comment #14
YesCT CreditAttribution: YesCT commentedComment #15
YesCT CreditAttribution: YesCT commentedthe issue was verified to still be a problem in #11 and #13. removing the tag.
Comment #16
alexpottThis issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 9792a0d and pushed to 8.0.x. Thanks!