Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Per Drupal secure coding standards at http://drupal.org/node/845876
md5 and sha1 should not be used any place in Drupal core since 7.0, but are re-introduced in the Block module for 8.x:
core/modules/block/lib/Drupal/block/Plugin/views/display/Block.php
197: $old_delta = md5($old_delta);
201: $md5_delta = md5($delta);
202: $hashes[$md5_delta] = $delta;
203: $delta = $md5_delta;
Comment | File | Size | Author |
---|---|---|---|
#4 | drupal-1884826-4.patch | 1.87 KB | dawehner |
#1 | 1884826-1.patch | 1012 bytes | pwolanin |
Comments
Comment #1
pwolanin CreditAttribution: pwolanin commentedLooks like this is also related to views in core, actually.
Comment #2
pwolanin CreditAttribution: pwolanin commentedComment #3
tim.plunkettThe code is in block module now. Tagging for VDC.
Comment #4
dawehnerA much simpler approach :P ... we don't have the block table anymore and so no need for these damn delta hashes.
Comment #5
olli CreditAttribution: olli commentedLooks good.
Comment #6
webchickYay less code. :D
Committed and pushed to 8.x. Thanks!
Comment #7
pwolanin CreditAttribution: pwolanin commentedNeeds backport to views 7.x of the original fix?
Comment #8
pwolanin CreditAttribution: pwolanin commentedIf backported to 7.x and a hash is needed, here is a better hash scheme (more bits used):
Which we use in facetapi for block deltas:
http://drupalcode.org/project/facetapi.git/blob/refs/heads/7.x-1.x:/face...
Comment #9
dawehnerWhat about just using a single place in views, as the code is in the same module.