It would be nice to differentiate between an entity type that can be rendered, and one that shouldn't.
If any class is actually using EntityRenderController, it should do that explicitly.

CommentFileSizeAuthor
#7 drupal-1882240-7.patch3.37 KBdawehner
#6 drupal-1882240-6.patch2.68 KBdawehner
render_controller_class.patch673 bytestim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

Agreed, everything having this default is useless for us to work out which entities can be rendered and which can't! +1

Status: Needs review » Needs work

The last submitted patch, render_controller_class.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

If we do something like that, we should certainly put something into entity_view_multiple to not fail totally, maybe throw an exception?

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Needs review
Issue tags: -VDC

render_controller_class.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC

The last submitted patch, render_controller_class.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
drupal-1882240-6.patch2.68 KB

Let's see what happens if you add to all content entities.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
drupal-1882240-7.patch3.37 KB

Added one for MenuLink and rerolled.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

Thanks!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Make sense. Committed/pushed to 8.x.

yched’s picture

yched CreditAttribution: yched commented

Yay !

Now rdf.module can stop running db queries whenever the definition of a (view|image style|input format|layout breakpoint...) is loaded :-p #1920498: Have rdf.module only act on renderable entities

Automatically closed -- issue fixed for 2 weeks with no activity.