Follow-up to: #80855: Add element #type table and merge tableselect/tabledrag into it

Blocked by

Goal

  • Remove obsolete render element #type 'tableselect'.
CommentFileSizeAuthor
#13 interdiff.txt10.57 KBstar-szr
#13 1876714-13.patch16.74 KBstar-szr
#12 interdiff.txt1.46 KBstar-szr
#11 1876714-11.patch6.76 KBstar-szr
#6 1876714-6.patch5.45 KBstar-szr
#1 drupal8.tableselect-die.1.patch10.23 KBsun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Issue summary: View changes

Updated issue summary.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Issue summary: View changes
Status: Postponed » Needs review
Issue tags: +@deprecated
Parent issue: » #80855: Add element #type table and merge tableselect/tabledrag into it
FileSize
drupal8.tableselect-die.1.patch10.23 KB

Let's see what breaks.

Expected:

Drupal\comment\Form\CommentAdminOverview
locale_translation_status_form()
Drupal\system\Tests\Form\ElementsTableSelectTest
database_test_theme_tablesort()
_form_test_tableselect_form_builder()
update_manager_update_form()

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Related issues: +#1938916: Convert locale theme tables to table #type

Out of the remaining usages in #1, there only appears to be one issue in the parent/meta list, so we probably have to convert/fix the other instances here.

Status: Needs review » Needs work

The last submitted patch, 1: drupal8.tableselect-die.1.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Parent issue: #80855: Add element #type table and merge tableselect/tabledrag into it » #1876712: [meta] Convert all tables in core to new #type 'table'
Related issues: +#80855: Add element #type table and merge tableselect/tabledrag into it
star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Assigned: Unassigned » star-szr

I'm starting to work on this.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Status: Needs work » Needs review
FileSize
1876714-6.patch5.45 KB

Initial work in progress patch, I know I'm missing something because most or all of the LocaleUpdate* tests are failing but there is only one example that uses the #tableselect => TRUE in core. I need to populate these tables with dummy data because running them through the simpletests is just not covering it.

Status: Needs review » Needs work

The last submitted patch, 6: 1876714-6.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented 
+++ b/core/modules/locale/src/Form/TranslationStatusForm.php
@@ -173,6 +172,7 @@ public function buildForm(array $form, array &$form_state) {
       $form['actions']['submit'] = array(
         '#type' => 'submit',
         '#value' => $this->t('Update translations'),
+        '#tableselect' => TRUE,

+++ b/core/modules/update/src/Form/UpdateManagerUpdate.php
@@ -263,6 +265,7 @@ public function buildForm(array $form, array &$form_state) {
       $form['actions']['submit'] = array(
         '#type' => 'submit',
+        '#tableselect' => TRUE,

why?

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented

That's how it works :) See https://www.drupal.org/node/1876710.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented

Taking another run at this.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Status: Needs work » Needs review
FileSize
1876714-11.patch6.76 KB

This should be green, I found and modified the #after_build that was previously emptying out rows for languages with no translation updates.

Edit: I also removed the now-redundant Drupal\locale\Form\TranslationStatusForm::validateForm().

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
FileSize
interdiff.txt1.46 KB

Missing interdiff.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
FileSize
1876714-13.patch16.74 KB
interdiff.txt10.57 KB

This is going to fail but this is as far as I've gotten so far. The colspan test is proving to be tricky. I haven't even begun to look into some of the validation tests.

Status: Needs review » Needs work

The last submitted patch, 13: 1876714-13.patch, failed testing.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Assigned: star-szr » Unassigned

Unassigning for now, haven't had the energy to jump back into this one.

jibran queued 13: 1876714-13.patch for re-testing.

The last submitted patch, 13: 1876714-13.patch, failed testing.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Issue tags: -@deprecated

Not actually an issue dealing with deprecation.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Version: 8.9.x-dev » 9.3.x-dev
Issue tags: +Needs issue summary update

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.