Review PluginUI architecture [#1875340]

Posted by xjm

Problem/Motivation

This is a followup issue for #1535868: Convert all blocks into plugins.

The PluginUI API introduced in #1535868: Convert all blocks into plugins has not undergone architectural review.
If a layout builder workflow is added to core, most of this UI will probably be replaced. However, if the plugin UI API is not cleaned up before Feb. 18, it needs to be improved separately.

Proposed resolution

Review the PluginUI class, the BlockPluginUI implementation, their derivative classes, and the use of PluginUI objects in the block module's procedural code.
Refine or refactor these classes as needed.

Remaining tasks

Related issues

Comments

Comment #1

sun

German

Karlsruhe

CreditAttribution: sun commented 30 December 2012 at 14:42

Issue tags:

-Needs architectural review

Hm, there's nothing to review here yet. Let's re-add the Needs architectural review tag when there is a true + elaborate summary of what actually needs architectural review. (Note that tagged issues are syndicated via RSS and also @drupalchanges on Twitter.)

Comment #2

xjm

she/her

English

CreditAttribution: xjm commented 3 January 2013 at 18:49

@sun, yes there is code to review, it's just in the patch in #1535868: Convert all blocks into plugins. In a couple days it will be in core, though. Edit: though you're right, we actually shouldn't be looking at this until after Feb. 18, which is why the issue is postponed.