Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I think we should be near a point where we can do this now. Move all the default views currently provided by views into their respective core modules. I think this should also mean we can kill the load() method we are overriding on the ViewStorageController.
But...
We currently have generic default views tests, that just test all of them at once.
Here is an initial patch. See how we get on.
Comment | File | Size | Author |
---|---|---|---|
#9 | 1863512-8.patch | 2.73 KB | damiankloip |
d8.move-default-views.patch | 2.68 KB | damiankloip | |
Comments
Comment #1
dawehnerIt seems to make sense to do this step by step in every actual conversion issue (tracker/frontpage etc.) and just keep the other ones here, maybe?
Comment #2
damiankloip CreditAttribution: damiankloip commentedComment #4
damiankloip CreditAttribution: damiankloip commentedd8.move-default-views.patch queued for re-testing.
Comment #6
dawehnerI'm wondering what happens if we had node installed, then views got enabled and then node get's removed again. The config files might not dissapear and then you end up with loading unwanted files?
Comment #7
damiankloip CreditAttribution: damiankloip commentedHmm, I guess at the moment the file will not be removed. Is there a configuration issue for this? Couldn't it look at the config files in it's own config directory and makes sure they are removed?
Comment #8
dawehnerMaybe we should ask heyrocker about that, but that's maybe/probably done by the config system itself?
Comment #9
damiankloip CreditAttribution: damiankloip commentedI'm talking with alexpott about this at DC London, it is definitely something the config system should handle but in fact doesn't atm.
Here is a re roll anyway.
Comment #11
dawehnerI propose to move the actual used views, but keep the example views (like glossary) in views.
Comment #12
damiankloip CreditAttribution: damiankloip commentedThat could be a good compromise I think.
Comment #13
dawehnerFill that as a novice task.
Comment #14
c_lehel CreditAttribution: c_lehel commentedI've started to look at this task because of the 'Novice' tag. I think due to the age of the issue many things have changed, or even got resolved.
comments_recent was moved to comment module, archive+frontpage+glossary were moved to the node module, taxonomy_term to the taxonomy module. I couldn't find the tracker and backlinks views, they were possibly renamed.
The controller, which is modified in the patch [ViewStorageController] I think was also removed/implemented elsewhere/in different way.
Comment #15
damiankloip CreditAttribution: damiankloip commentedIndeed, thanks for bringing this back up!
None of these are left in views now, all have been moved to their respective modules.