Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The patch in #594660: Rename default menu names the 'block-menu' class as well as the 'role="navigation"' property to no longer appear on system menu blocks. (@see system_preprocess_block() ... the part in 'default:' in the switch never evaluates to TRUE because the block delta always has a 'menu-' prefix while the output of menu_list_system_menus() doesn't.
Comment | File | Size | Author |
---|---|---|---|
#3 | 1863180-3.patch | 2.03 KB | fubhy |
system-menu-block.patch | 767 bytes | fubhy | |
Comments
Comment #1
tim.plunkettThis needs tests, but it will also break #1535868: Convert all blocks into plugins.
Maybe postpone it til after that?
Comment #2
sunThe patch looks good. Let's add a quick and simple assertion line to an existing (System) menu test (hopefully there are some) and get this fixed.
Comment #3
fubhy CreditAttribution: fubhy commentedWe don't have a 'system' menu test. So I put this into the block test... Not sure if that's the right place for this because, well, its a system module block. But I didn't want to add a new test just for this simple assertion.
Comment #5
fubhy CreditAttribution: fubhy commentedYeah right...
Comment #6
fubhy CreditAttribution: fubhy commented#3: 1863180-3.patch queued for re-testing.
Comment #17
pameeela CreditAttribution: pameeela commentedBoth role="navigation" and class="block-menu" there now and seemingly the role is to be removed soon in #2655794: Remove redundant WAI-ARIA role attributes from <main>, <nav>, <aside>, <header>, and <footer> elements.