Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Follow up for #1810386: Create workflow to setup multilingual for entity types, bundles and fields
Problem/Motivation
#1810386-71: Create workflow to setup multilingual for entity types, bundles and fields Started an accessibility review.
#1810386-124: Create workflow to setup multilingual for entity types, bundles and fields Addressed request for label for=
This is a follow-up for ARIA and other accessibility focused investigation and careful review. This issue is for remaining accessibility work on the translation settings page. Note that some of the other usability follow-ups to that issue might also improve general accessibility and those general improvements dont need to be addressed here.
Proposed resolution
#1810386-114: Create workflow to setup multilingual for entity types, bundles and fields
Remaining tasks
- Read ARIA docs carefully.
- Add comments listing specific changes to make
- Implement some, create patches
- Get more reviews
- Rinse. Repeat.
Find other things todo
- Get more types of accessibility reviews, screen reader, having someone just try using the page without a mouse.
- Get the point of view of some of the experienced accessibility reviewers in the community
- http://drupal.org/node/1853532 doc page: Contributor task: Manually do Accessibility testing of a patch for a Drupal issue could be helpful for people wanting to jump in
User interface changes
(new or changed features/functionality in the user interface, modules added or removed, changes to URL paths, changes to user interface text)
API changes
No api changes expected.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | label-notes.txt | 2.92 KB | YesCT |
Comments
Comment #1
YesCT CreditAttribution: YesCT commentedHere is something I tried to do.
Comment #2
mgiffordThanks for this @YesCT
Can you give me a bit of a better sense of what you are doing with label-notes.txt?
Hidden elements are definitely a problem (as are labels). We've made some improvements and ultimately I think we're going to have to add ARIA to provide the additional semantics to screen reader users.
Comment #3
YesCT CreditAttribution: YesCT commentedI think I need to read the links from #1810386-114: Create workflow to setup multilingual for entity types, bundles and fields.
You asked for a better sense of what I was doing with the label:
(from #1810386-100: Create workflow to setup multilingual for entity types, bundles and fields)
Comment #4
YesCT CreditAttribution: YesCT commentedrepurposing for general ARIA / accessibility follow-ups.
Comment #5
plachLet's wait for the wizard patch to be committed.
Comment #6
mgiffordwe're there now, right - https://drupal.org/node/1810386#comment-6885090
Comment #7
YesCT CreditAttribution: YesCT commentedyep! #1810386-185: Create workflow to setup multilingual for entity types, bundles and fields
and also #1877048-7: Make Translation entity module JS follow newer core rules
Comment #8
mgiffordOk, so we need to identify where other patches need to be made and try to re-roll some. We've been successful in introducing a lot of ARIA, but there's still a long ways to go.
Comment #9
Dragan Eror CreditAttribution: Dragan Eror commentedI've checked the Content language settings page (admin/config/regional/content-language) with ChromeVox - Screen reader (Chrome extension). And when I used sticky mode, everything was easily accessible and readable without using mouse, except options from combo boxes. ChromeVox can't read options from combo box until option is selected, but that is probably because options are part of OS not browser.
Using "role" attribute or any of "aria-" attributes would be useful if we would like to use wrapper to group some elements and inform screen readers about that, but we do not use such a grouping.
The one more case where "aria" would be useful is on tables with sortable columns which is not the case on this page.
Comment #10
mgifford@Dragan, sounds great! So is there a #SprintWeekend where you are going to be able to roll up a patch?
How can we help improve the grouping elements for translation?
Also totally appreciate ideas on how to improve sortable tables too. Might make sense to just set up a new issue for that one though as tables are used so much throughout Core.
Comment #11
falcon03 CreditAttribution: falcon03 commentedOne improvement I was thinking about is adding a live region to let blind users know that fields are shown or hidden when enabling or disabling translation for an entity bundle. @mgifford, what do you think about this?
This would be super-easy to do with the new drupalAnnounce() method :-)
Comment #12
mgiffordJust as a follow-up #1915302: Provide an API for aria-live region update announcements that module developers may leverage is where this was added
Also we're trying to apply it here too #1272990: Make tabledrag warning message show when row weights are enabled, and add WAI-ARIA live region
Comment #13
Gábor HojtsyComment #14
mgiffordtagging
Comment #14.0
mgiffordlabel for= was done in the parent issue. use this for the rest.
Comment #15
jcnventura CreditAttribution: jcnventura commentedPlease consider also this related issue during those ARIA improvements, as it's the label for the content-type-specific content translation flag.
Comment #26
quietone CreditAttribution: quietone at PreviousNext commentedThe proposed resolution in the Issue Summary is an issue that was fixed in Drupal 8.x.
Either this can be closed as outdated or there is still work to do.
Since we need more information to move forward with this issue, I am setting the status to Postponed (maintainer needs more info).
Thanks!
Comment #29
smustgrave CreditAttribution: smustgrave at Mobomo commentedIf still a valid task please reopen updating issue summary.
THanks!