As I noticed in #1811816-30: Benchmark node_page_default vs. node view, we're executing *a lot* of checksum tag queries, that should not be happening.

There are other issues and more plans to improve cache tag handling, but these might or might not make it into 8.x. Fixing this is a must I think and should be relatively simple to fix, as it's not supposed to happen.

CommentFileSizeAuthor
#1 remove-config-cache-tags.patch1.75 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Active » Needs review
FileSize
remove-config-cache-tags.patch1.75 KB

Ok, there might be more but this is probably the biggest offender.

Config/CachedStorage adds a default tag that is the same as the actual cache cid. Removing that gets the checksum queries on the frontpage from 47 down to 10.

olli’s picture

olli CreditAttribution: olli commented

Looks good to me - similar numbers here, and can't find code invalidating those tags. This actually revealed that the static $tagCache works only for invalidated tags.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Component: cache system » configuration system
Status: Needs review » Reviewed & tested by the community

Nice find. Three lashes to the person who committed the original patch (self-flagellates).

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.