Consolidate Seven button styles

I totally agree - that looks anything but consistent.

Related: #1845728: Refactor and introduce generic button CSS styles for forms and links — but that won't change anything for Seven's concrete/custom button styles, so this has to be adjusted here.

Oh! And as soon as #1168246: Freedom For Fieldsets! Long Live The DETAILS. has landed, this sounds like a super critical and perfect new design test case! :)

#1848432: Visually Differentiate the second level of the toolbar more clearly from the content region
#1848428: Make the primary action buttons color and shape correlate with "Save" button and other buttons
and
#1238484: Ability to mark the form buttons to be of a specific type (so that they can be styled differently)

To me this is just a side-effect of this phase, I generally don't even bother giving visual reviews anymore even on things like the toolbar. We can clean it up nicely after code freeze, and we should have a more profound style guide or this will always happen.

@Lewis - Sassy's buttons look good to me.

@Bojhan - I'm not one for writing a solid style guide, but certainly support it.

With help from Bojhan and yoroy, I’ve been drafting an updated and unified set of styles for Seven, including buttons. It should make its way to the issue queue soon, and the idea is for it to evolve into a style guide. Besides consistency, I’m also trying to make sure every element is careful to reflect Drupal’s personality, or – for lack of a better term – brand. Look for more on this in the near future :)

That's great. Any chance they will be available in a .svg format so that we can modify them with http://inkscape.org and add it to a git repo?

@mgifford Right now all the graphic work is in Photoshop. However, once there is a basic consensus on the design direction, my plan is to throw out the .psd and iterate in HTML and CSS. That way, we get the benefit of working in the 'real thing' and open up participation. Plus, the ‘style guide’ starts to bridge the gap with an actual theme component library. Ultimately, the best style guide is a 'living style guide': generated from the same code used for Drupal’s normal output. It would serve to illustrate (and test) of all of the available UI components (run through a given theme) with inline rationale and usage guidelines for each component.

Sounds great! Thanks @ry5n.

In addition to the button styles in the original post, there is also the gray, less-rounded button used in .form-actions. It's totally crazy that Seven uses rounded buttons *unless* it's in the .form-actions wrapper, where buttons are mostly square. Continuing the madness, the .button-primary class doesn't provide any visual difference because the .form-actions button CSS overrides it, so all buttons at the end of forms are always gray now, instead of the primary button having any special identification. Totally crazy.

I'd like it if this issue were attempted sooner rather than later. Trying to use the Views interface without any indication of primary buttons is a lot more difficult than it would seem.

After #1851414: Convert Views to use the abstracted dialog modal is finished up, we'll also need to provide some styling for buttons in modals. IMO these should be consistent with other buttons, but jQuery UI's default styling may require some additional overriding.

So am I correct the style guide has clear instructions how this has to look?
If it does, it would save a lot of the discussion part.

@eigentor Yes. The style guide proposes a unified style for all buttons in Seven that I believe covers all our current use cases. We’ve started prototyping this in a sandbox project: http://drupal.org/sandbox/ry5n/1932040.