Change variable xmlrpc_test_xmlrpc_alter to the state system. [#1848066]

Comment	File	Size	Author
#9	1848066-xmlprc_to_state-drupal8-9.patch	1.9 KB	ACF

#7	1848066-xmlprc_to_state-drupal8-7.patch	18.91 KB	ACF

#4	1848066-xmlprc_to_state-drupal8-4.patch	1.89 KB	Gaelan

#1	1848066-xmlprc_to_state-drupal8-1.patch	1.88 KB	ACF

Comment #1

ACF CreditAttribution: ACF commented 22 November 2012 at 17:26

Status:

Active

» Needs review

File	Size
1848066-xmlprc_to_state-drupal8-1.patch	1.88 KB

Patch attached.

Log in or register to post comments

Comment #2

gdd

he/him

English

Portland, OR

CreditAttribution: gdd commented 23 November 2012 at 19:41

Status:

Needs review

» Needs work

+++ b/core/modules/xmlrpc/tests/modules/xmlrpc_test/xmlrpc_test.moduleundefined
@@ -68,7 +68,7 @@ function xmlrpc_test_xmlrpc() {
-  if (variable_get('xmlrpc_test_xmlrpc_alter', FALSE)) {
+  if (state()->get('xmlrpc_test.xmlrpc_alter')) {

This needs a default value.

Otherwise looks fine.

Log in or register to post comments

Comment #3

gdd

he/him

English

Portland, OR

CreditAttribution: gdd commented 23 November 2012 at 20:16

I'm sorry I'm stupid. The state() system does not use default values like the variable system does. This needs to be converted to something like

$xmlrpc_alter = state()->get('xmlrpc_test.xmlrpc_alter') ?: FALSE;
if ($xmlrpc_alter) {

I'd rather not put the ternary in the if but that's just me.

I also wouldn't mind seeing the name changed to 'xmlrpc_test.alter' because the second xmlrpc seems redundant.

Log in or register to post comments

Comment #4

Gaelan CreditAttribution: Gaelan commented 23 November 2012 at 20:21

File	Size
1848066-xmlprc_to_state-drupal8-4.patch	1.89 KB

Fixes concerns in #3.

Log in or register to post comments

Comment #5

Gaelan CreditAttribution: Gaelan commented 23 November 2012 at 20:21

Status:

Needs work

» Needs review

I am forgetful.

Log in or register to post comments

Comment #6

23 November 2012 at 22:08

Status:

Needs review

» Needs work

The last submitted patch, 1848066-xmlprc_to_state-drupal8-4.patch, failed testing.

Log in or register to post comments

Comment #7

ACF CreditAttribution: ACF commented 24 November 2012 at 15:12

Status:

Needs work

» Needs review

File	Size
1848066-xmlprc_to_state-drupal8-7.patch	18.91 KB

Attached a patch with the changes requested.

I'm not sure why the state()->get needs a default value, as it was in the if statement and it will fail the conditional statement either with false or null?