Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Breadcrumb Home » Administration » Structure » Menus » Tools found on http://drupaltestbot983-mysql/checkout/admin/structure/menu/item/6/edit.
Other BreadcrumbTest.php 117 Drupal\system\Tests\Menu\BreadcrumbTest->testBreadCrumbs()
The test passes locally.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | drupal-1836204-5.patch | 1.09 KB | dawehner |
Comments
Comment #1
sunThis will be fixed as part of #347988: Move $user->data into own table
The essential fix is: http://drupal.org/files/interdiff_1767.txt
Comment #2
tim.plunkettThen it is not fixed.
Comment #3
tim.plunkettThe implication was that it would be fixed right away by that issue, but that stalled, and this is wholly unrelated to it.
Random test failures are usually criticals, right? This is blocking several issues.
Comment #4
sunSure, I provided a link to the interdiff in #1 that contains the essential test fix.
Comment #5
dawehnerIt seems to be for me, that in #1783196: Get the views plugin manager from the DIC when possible it's not even a random test failure.
Upload the patch from sun.
Comment #6
sunComment #7
BerdirI would argue that this is not a *random* test failure, because in both cases, it did happen when changes causes menu items to be created in different orders and then it happened always. It's just a hardcoded assumption that shouldn't be one.
But that's a detail, the patch is RTBC :)
Comment #8
webchickCommitted and pushed to 8.x. Thanks!
Comment #9
dawehnerThanks for the getting this one in!
Comment #10
dawehnerThe remaining problem seems to be #1780396: Namespaces of disabled modules are registered during test runs
See failing test: http://qa.drupal.org/pifr/test/382018
Comment #11
dawehnerReopen this issue.
Comment #12
sunmmm, that looks like a different/separate issue to me, which isn't really caused by a improperly authored test, but rather a systematic/architectural problem.
Comment #13
BerdirYes, I think those failures are due to the namespaces problems, I made #1836008: Remove drupal_classloader() use in Drupal\Core\AnnotatedClassDiscovery a critical now to get this resolved. I don't know why exactly it only happens to certain patches, but it's reproducable in e.g. #1292470-221: Convert user pictures to Image Field.
Doesn't have anything to do with why this issue was opened originally IMHO, so marking it as fixed.
Comment #14
BerdirNote to anyone listening here. Not the real real fix, but we identified how this can be fixed without having to fix the whole namespace thing: #1848200: Random warnings in tests in field_ui.admin.inc.