Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up

Run jshint on the files with the configuration from the parent issue or use jshint.com with the following options:

/*jshint forin:true, noarg:true, eqeqeq:true, undef:true, curly:true, browser:true, expr:true, latedef:true, newcap:true, trailing:true */
/*global drupal, jQuery */

Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionality.
Create patch and upload for the testbot.

Files: modules/views/js/base.js

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rballou’s picture

Initial pass for jshint:

base.js: line 9, col 3, 'Drupal' is not defined.
base.js: line 14, col 3, 'Drupal' is not defined.
base.js: line 46, col 3, 'Drupal' is not defined.
base.js: line 68, col 3, 'Drupal' is not defined.
base.js: line 70, col 16, 'Drupal' is not defined.
base.js: line 83, col 3, 'Drupal' is not defined.
base.js: line 96, col 3, 'Drupal' is not defined.
base.js: line 97, col 12, 'Drupal' is not defined.
base.js: line 98, col 27, 'Drupal' is not defined.
base.js: line 15, col 30, 'context' is defined but never used.

10 errors
rballou’s picture

Patch attached.

rballou’s picture

Status: Active » Needs review
tim.plunkett’s picture

Status: Needs review » Needs work
Issue tags: +Needs manual testing

As in the other issues, please change it all back to Drupal, not drupal.

tim.plunkett’s picture

Issue tags: +VDC

Tagging VDC as well.

rballou’s picture

Status: Needs work » Needs review
FileSize
488 bytes

Updated with patch to keep Drupal as Drupal

nod_’s picture

Status: Needs review » Reviewed & tested by the community
webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.