Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up
Run jshint on the files with the configuration from the parent issue or use jshint.com with the following options:
/*jshint forin:true, noarg:true, eqeqeq:true, undef:true, curly:true, browser:true, expr:true, latedef:true, newcap:true, trailing:true */
/*global drupal, jQuery */
Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionality.
Create patch and upload for the testbot.
Files: modules/views/js/base.js
Comment | File | Size | Author |
---|---|---|---|
#6 | core-js-jshint-views-base-drupal.patch | 488 bytes | rballou |
#2 | core-js-jshint-views-base.patch | 2.26 KB | rballou |
Comments
Comment #1
rballou CreditAttribution: rballou commentedInitial pass for jshint:
Comment #2
rballou CreditAttribution: rballou commentedPatch attached.
Comment #3
rballou CreditAttribution: rballou commentedComment #4
tim.plunkettAs in the other issues, please change it all back to Drupal, not drupal.
Comment #5
tim.plunkettTagging VDC as well.
Comment #6
rballou CreditAttribution: rballou commentedUpdated with patch to keep Drupal as Drupal
Comment #7
nod_Comment #8
webchickCommitted and pushed to 8.x. Thanks!