Convert css_gzip_compression and js_gzip_compression variables to CMI system

Tagging

Needs a hook_update_N in system.install.

The update function description needs works - 80 characters and capitalisation.

In default.settings.php there are the following variables commented out by default

# $conf['css_gzip_compression'] = FALSE;
# $conf['js_gzip_compression'] = FALSE;

These should be changed to use the new format for referring to config variables in $conf, which is $conf[<config_object_name>][<config_variable>]. So this should become

# $conf['system.performance]['gzip_compression.css'] = FALSE;
# $conf['system.performance]['gzip_compression.js'] = FALSE;

+++ b/sites/default/default.settings.phpundefined
@@ -458,8 +458,8 @@
+# $conf['system.performance]['gzip_compression.css'] = FALSE;
+# $conf['system.performance]['gzip_compression.js'] = FALSE;

There's two missing single quotes... at the end of system.performance

#13: 1824778-css_gzip_compression-js_gzip_compression-7.patch queued for re-testing.

Just rerolling and seeing if the testbot wakes up.

#16: 1824778-css_gzip_compression-js_gzip_compression-16.patch queued for re-testing.

Code looks good to me, pending a retest.

#16: 1824778-css_gzip_compression-js_gzip_compression-16.patch queued for re-testing.

Fixed duplicate update function name.

Is using both "gzip" and "compression" in the key redundant? Couldn't they just be "gzip.css" and "gzip.js"? Note that "response.gzip" is just that, not "response.gzip_compression".

I agree with #22 gzip.js and gzip.css is concise and meaningful.

+++ b/core/modules/system/config/system.performance.ymlundefined
@@ -8,3 +8,6 @@ preprocess:
 response:
   gzip: '0'
+gzip_compression:
+  css: '1'
+  js: '1'

hmmm...

Actually this could then become...

gzip:
  response: '0'
  css: '1'
  js: '1'

That, or maybe

cache:
  page:
    enabled: '0'
    max_age: '0'
css:
  preprocess: '0'
  gzip: '1'
js:
  preprocess: '0'
  gzip: '1'
response:
  gzip: '0'
stale_file_threshold: '2592000'

I like the proposal in #25

Did a re-roll of the patch but changed the system.performance.yml config file to look like the layout in #25. It meant I had to rename the preprocess variables.

This looks good to me, and I like the new file layout a lot better. Thanks!

Just rerolling for system.install upgrade number hopefully can go back to rtbc.

Applies, and looks good from here!

Committed to 8.x. Thanks.

I'm not sure this was entirely OK to convert as is:

- the $conf overrides were mainly useful in the case that you had page_cache_without_database enabled, that's broken at the moment - see #1576322: page_cache_without_database doesn't return cached pages without the database which I've just re-opened, but this patch added to the inability to do that.

- if there's a UI for these and we're going to require CMI access to serve cached pages whatever happens, then they could be removed from settings.php

- should we reverse the extension_load() and the config() calls? - this would save loading the configuration object if it's never going to needed anyway.

@catch I can't see how the ability to return a cached page without the database is affected by this one. The compression config should not be accessed if we are doing this.

So yep let's remove from settings.php and you're correct that we should swap the extension_load and config calls.

Updated issue summary.

Opened #1824778: Convert css_gzip_compression and js_gzip_compression variables to CMI system

It is #2183075: Tidy up css.gzip and js.gzip configuration. :-) Thanks for the followup @alexpott.