During the drupal installation, each page has a title wrapped into an "h1" heading. This title is shown just before the drupal logo.

My proposal is to place it after the "installation tasks", right before the page content, as it was in D7. In my opinion this could let a blind user to find easier the main page content...

Any thoughts?

Comments

mgifford’s picture

It would be useful to see the html before & after to be able to see the change. If it's a regression it's going to be a higher priority to fix.

Why would it make it easier for blind users? I'm assuming because it's easier to navigate between headings & that by having it over the main page content (like is the default for most Drupal pages), you can jump right to the content after navigating to that section.

falcon03’s picture

Hi Mgifford,

that's right: your assumptions are totally correct!

Well, I tried to check drupal 7 installation process and (if memory isn't leaving me) sometimes has changed between drupal 7 maintenance releases: with drupal 7.15 the installation process has the same drupal 8 installation issues; but I remember that the first time I installed drupal I didn't notice this issue...

mgifford’s picture

I just checked in D7 and the H1 also comes before <div id="page"> so it's not a regression.

However, it is inconsistent with the Drupal themes & logic in general. This page for example has the H1 tag at the beginning of the content.

I think this just needs some pretty basic HTML changes and some CSS modifications to see that it all looks consistent.

I'm not sure that it's major though compared to other accessibility issues in the queue.

mgifford’s picture

So I looked into this briefly on the plane and thought it boiled down to the maintenance-page.html.twig file in Seven:

  <header id="branding">
    {% if title %}<h1 class="page-title">{{ title }}</h1>{% endif %}
  </header>

Which was coming from theme.inc

function template_preprocess_install_page(&$variables) {
  template_preprocess_maintenance_page($variables);
  // Override the site name that is displayed on the page, since Drupal is
  // still in the process of being installed.
  $variables['site_name'] = drupal_install_profile_distribution_name();
}

but now I'm on the ground it's clear install-page.html.twig is being called as the source looks like:

        <div id="header">
                      <h1 id="site-name">
              <span>Drupal</span>
            </h1>
        </div> <!-- /header -->
        <div id="container" class="clearfix">
              <h1 class="title" id="page-title">Choose language</h1> 

I've got concerns with how the install-page.html.twig is so much different than the maintenance-page.html.twig files in system, bartik & seven.

It's not really a huge deal to have 2 H1 headers I don't think, but when there are only 2 headers it's a bit silly. Also, surely it the would be better if the header H1 should be <header><h1>Drupal Installation</h1></header> and the stage should be <h2>Choose language</h2>.

Having 2 H1's is at least consistent with system/templates/maintenance-page.html.twig

@falcon03, can you look again at this since #1337554: Develop and use separate branding for the installer rewrote this all.

mgifford’s picture

Issue summary: View changes
Status: Active » Postponed (maintainer needs more info)

So right now there are two h1's. One for the header for the site in general:

  <header role="banner">
          <h1 class="page-title">Drupal</h1>
      </header>

Another for the section of the install you're presently on:

  <main role="main">
          <h1>Database configuration</h1>

We can bring it down to one H1 per page, but probably not till 8.1.x at this stage.

jhedstrom’s picture

Version: 8.0.x-dev » 8.1.x-dev

Feature request => 8.1.x.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

Status: Postponed (maintainer needs more info) » Closed (outdated)

Moving to outdated since there hasn't been movement since it was marked PNMI 8 years ago

If you still feel it's an issue please reopen with an updated issue summary.