Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.While doing a review of the Tracker module from a documentation perspective, it appears that class member variables access_user and no_access_user are not used. These at minimum should be removed and a thorough coding review of the two tests performed.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | tests-cleaned-up-1813318-7.patch | 1.97 KB | Palashvijay4O |
| #3 | tracker_cleanup-1813318-3.patch | 1.15 KB | kfritsche |
Comments
Comment #1
Lars Toomre CreditAttribution: Lars Toomre commentedThe TrackerTest.php class uses both the Tracker and Comment modules in its tests. In the setUp() function for this class, there is a variable_set('commnet_preview_page', 0). Doing a grep through core code, I find no other reference to this particular variable.
I suspect that at some point the variable was converted to config/state sub-systems and this was overlooked. Anyone have an idea of what this should be converted to?
Comment #2
penyaskitoTagging.
Comment #3
kfritscheReviewed both tests too. Others from your comment, it seems fine to me.
Deleted both unused member variables.
The variable 'comment_preview_'.$type (in this case 'page') is still used. Therefore only added the TODO right now.
I'm going to search now for the comment issue to remove the variables in the comments module and will come back here later again, if this is finished.
Comment #5
kfritsche#1776076: Convert comment module configuration to CMI is the CMI issue for the comment.module.
Setting this to postponed, till this is fixed.
Comment #6
mgiffordit is.
Comment #7
Palashvijay4O CreditAttribution: Palashvijay4O commentedSubmitting a patch.
Comment #11
rpayanmVariables
access_userandno_access_userin class core/modules/tracker/src/Tests/TrackerNodeAccessTest.php not longer exist.Comment #12
rpayanm