Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a sub-issue of #1800046: [META] Add missing type hinting to core docblocks, fix Drupal.Commenting.FunctionComment.Missing* focused on correctly adding @param and @return type hinting to the Statistics module.
Documentation patches that include type hinting are time consuming to both review and commit because one must dig into the actual code to confirm that the type hints are both correct and complete. Hence, please be patient and try to limit type hint patches to covering only a limited number of docblocks (10-15 as a guess).
How To Review This Issue
- Attempt to apply the patch to see if it needs a reroll.
- Use the phpcs one-liner to evaluate whether all the relevant standards errors have been resolved: https://gist.github.com/paul-m/227822ac7723b0e90647
- Look at each change and determine whether the type hint is correct.
Related sprint issues:
Comment | File | Size | Author |
---|---|---|---|
#2 | 1811892_2.patch | 942 bytes | Mile23 |
Comments
Comment #1
Mile23Comment #2
Mile23Not a lot to worry about here.
Comment #3
Mile23Still applies.
Comment #4
Mile23Comment #5
deepakaryan1988Looking good to me.
Converting to RTBC
Comment #6
xjmChanging this comment is scope creep, so technically not correct in this patch, but I chose to commit it in this case. However, please be sure in the future to restrict cleanups and fixes to what specified in the issue scope. Thanks! Committed and pushed to 8.0.x.