API page: http://api.drupal.org/api/drupal/core%21modules%21aggregator%21aggregato...
Enter a descriptive title (above) relating to hook_aggregator_process_info, then describe the problem you have found:
As far as I can tell, hook_aggregator_process_info() is never invoked with a $feed argument. Yet the docs for D7 and D8 have such an (undocumented) argument. I think it should be removed... the only invocation I see is in aggregator_admin_form() and it doesn't pass in $feed.
Although this is purely a documentation issue, I'm putting it temporarily in the aggregator module component so the maintainers can comment on whether the $feed argument to the hook should or shouldn't be there (maybe there's an invocation that api.drupal.org is not picking up?).
Comment | File | Size | Author |
---|---|---|---|
#3 | 1811218-remove-feed-from-hook-aggregator-process-info.patch | 523 bytes | chertzog |
Comments
Comment #1
dozymoe CreditAttribution: dozymoe commentedLooks like the
$feed
argument forhook_aggregator_process_info()
is a typo, started here Pluggable architecture for aggregator.module.At first it was
hook_aggregator_process($op, $feed = NULL)
with $opt being 'save', 'unique', 'info', like it was in Drupal 6. Then each $op become its own hook functions while keeping the$feed
argument.In the original function, the
$op == 'info'
do not make use of the $feed argument:Also, the aggregator module itself implements hook_aggregator_process_info() without
$feed
argument.Comment #2
ParisLiakos CreditAttribution: ParisLiakos commented#1930274: Convert aggregator processors and parsers to plugins takes care of that for d8, moving to d7
Comment #3
chertzogHere's a patch.
Comment #4
ParisLiakos CreditAttribution: ParisLiakos commentedthanks!
Comment #5
jhodgdonYes, thanks! I'll get this committed shortly.
Comment #6
jhodgdonThanks again - committed to 7.x.