This is a sub-issue of #1800046: [META] Add missing type hinting to core docblocks, fix Drupal.Commenting.FunctionComment.Missing* focused on correctly adding @param and @return type hinting to the bsae test classes in the Simpletest module.

Documentation patches that include type hinting are time consuming to both review and commit because one must dig into the actual code to confirm that the type hints are both correct and complete. Hence, please be patient and try to limit type hint patches to covering only a limited number of docblocks (20-25 as a guess).

Related sprint issues:

Sprint Topic Sub Issue
#1518116: [meta] Make Core pass Coder Review N.A.
#1310084: [meta] API documentation cleanup sprint #1805264: Clean up API docs for Test base classes in Simpletest module
#500866: [META] remove t() from assert message #1803674: Remove t() from default test assertions in TestBase class

Comments

Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented

Postponing until #1805264: Clean up API docs for Test base classes in Simpletest module is committed to D8.

Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented
Status: Active » Postponed
mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Issue summary: View changes
Status: Postponed » Closed (won't fix)
Related issues: +#1805264: Clean up API docs for Test base classes in Simpletest module

Unless there's another way around this..

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Parent issue: » #1800046: [META] Add missing type hinting to core docblocks, fix Drupal.Commenting.FunctionComment.Missing*
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Closed (won't fix) » Closed (duplicate)

The latest patch in #1805340: Add missing type hinting to Simpletest module docblocks (excluding test base classes) includes the SimpleTest base classes.