Created from #1775842: [meta] Convert all variables to state and/or config systems.
The following variable/file pairs need to be converted:
allow_authorize_operations authorize.php
allow_authorize_operations update.module
authorize_filetransfer_connection_settings_ . $backend authorize.inc
authorize_filetransfer_default authorize.inc
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | authorize_variables_to_config-1804346-10.patch | 4.78 KB | 8thom |
| #8 | authorize_variables_to_config-1804346-8.patch | 4.63 KB | 8thom |
| #6 | authorize_variables_to_config-1804346-6.patch | 4.73 KB | 8thom |
| #2 | authorize_variables_to_config-1804346-2.patch | 3.46 KB | 8thom |
Comments
Comment #1
Anonymous (not verified) commentedadding tag.
Comment #2
8thom commentedVariable references converted
Comment #3
8thom commentedComment #4
aspilicious commentedauthorize_filetransfer_default isn't listed in the config file, is there a way to list it anyway, for discoveribility reasons.
All config items are stored as strings. In most cases we choose '1' as true.
Comment #5
alexpottYep we should list authorize_filetransfer_default in the yaml file if possible... and we can make the config names simple now they are in the system.authorise namespace.
Plus we need an update function to migrate the variables to config during a D7 to D8 upgrade see system_update_8009() as an example.
Comment #6
8thom commentedHope the numbering is ok for the update hook, does this get reassigned before the final commit?
Comment #7
aspilicious commentedYou're making a D7 to D8 upgrade function so the name of the upgrade function must be 8030 (if it isn't increased in the meantime)
Comment #8
8thom commentedThanks aspilicious.
Updated system_update function to system_update_8030
Comment #10
8thom commentedfixed patch
Comment #11
aspilicious commentedLooks good to me. I hope I didn't missed something.
Comment #12
webchickHuh, interesting. Didn't know you could do that as an equivalent of NULL.
Committed and pushed to 8.x. Thanks! So great to see these conversion issues getting picked off, especially by new core contributors! :)
Comment #14
8thom commented