[policy/patch] Standardize on "installation profile" instead of "install profile"

Since there are only 30-something instances that need changing, this probably doesn't need to be a meta-issue -- we can do them all in one patch. I propose that we make a patch that standardizes on "installation", and leave it at RTBC for a few days in case anyone objects.

We should also add this to
http://drupal.org/style-guide/content
once we've agreed upon a standard.

+1 to both the proposed change, and the proposed method. One patch is infinitely easier to review + commit than 30. :) For ones that are just straight-up find + replace (as opposed to changes that do need individual human review), this is a good approach.

I noticed:
#1802280: Incorrect documentation in drupal_system_listing()
But that is a separate issue.

I think this patch is good (thanks!), so I'm provisionally marking it RTBC to see if anyone objects to the idea of standardizing on "installation profile" -- let's wait a couple of days before committing it.

I also think everything except the translated string change (I think there's only one) can be ported to Drupal 7 as well (and should be).

Sounds fine to me, fwiw. Feels more like a task and not something that should be subjected to thresholds, so re-categorizing.

Jennifer can drive this home, so assigning to her so I don't factor it into my RTBC queue count. :)

Fine with me too.

Well, this has been RTBC with proper tags for a few days. No one has objected and two heavy-hitters have agreed, so I went ahead and committed this. Time to backport to 7!

I also edited
http://drupal.org/style-guide/content#relatedwords
to add this textual standard.

Thanks, this looks great!

The only thing is, we don't want to make changes to translated strings in D7, so we need to remove these changes:

-      'display_name' => count($install_state['profiles']) == 1 ? st('Install site') : st('Install profile'),
+      'display_name' => count($install_state['profiles']) == 1 ? st('Install site') : st('Installation profile'),

-    $this->assertIdentical(drupal_get_filename('profile', 'standard'), 'profiles/standard/standard.profile', t('Retrieve install profile location.'));
+    $this->assertIdentical(drupal_get_filename('profile', 'standard'), 'profiles/standard/standard.profile', t('Retrieve installation profile location.'));

-        'title' => $t('Install profile'),
+        'title' => $t('Installation profile'),

Regarding patch names, don't worry about that! If the issue is D7, then we'll know the patch is for D7. :)

Anyway, this looks good, and I'll get it committed shortly. Thanks!

Committed... thanks again for your work on this jwilson3!

-      'display_name' => count($install_state['profiles']) == 1 ? st('Install site') : st('Install profile'),
+      'display_name' => count($install_state['profiles']) == 1 ? st('Install site') : st('Installation profile'),

This one is wrong for Drupal 8 also, since "install" was being used as a verb here. (I.e., compare to "Choose profile" which is one of the earlier installation tasks.)

I just installed a new copy of Drupal 8 and got really thrown off by the new wording.

Here's a patch which fixes that.

Hm. Would it be more correct then to call this step "Choose installation profile"? You're not actually installing anything here.

I'm not sure how that jibes with the rest of the task labels in terms of length, though.

The step where you choose an installation profile is already called "Choose profile". This is the step where the modules are being enabled.

Attached screenshot may help.

I suppose it would be possible to rename them both ("Choose installation profile" and "Enable installation profile"), but that would get long and would probably spill over into more than one line. As can be seen in the screenshot, they're already spilling to multiple lines as it is, but that's some kind of D8 theming bug (because the entire task list is squished horizontally) - in D7 they all are on one line, at least for me.

David: Thanks for catching that mix-up!
RE #24 - I think "Install site" makes more sense -- option (a). Option (b) to me is a bit jarring because everything but "Installation" is a verb... and really the whole process is "installation"... Some of the other steps don't make a whole lot of sense either, given what they actually do. And there are also some other steps that aren't shown in this list, under certain circumstances. The whole list (for people installing in non-English languages) is currently:

Choose language [user chooses a language]
Choose profile [user chooses a profile to use]
Verify requirements [system checks requirements]
Set up database [user enters database information, system verifies it can connect]
Install site/Install profile [modules/themes are installed]
Set up translations [system sets up languages and imports translations it knows about]
Configure site [user enters site information, system saves it]
(tasks added by your profile)
Finish translations [import remaining translations if any]
Finished

So... I'm not really thrilled by "Install site", since to me the whole process is "installing a site", right? Also not thrilled with "Set up database", since the database tables are not set up until the next step really. And one of the "set up" steps means "you enter information", while the other is "the system sets stuff up"... So how about if we change this to:

Choose language
Choose profile [should this be "Choose installation profile"? or is that too long? did we discuss above?]
Verify requirements
Configure database
Install database
Install translations
Configure site
(tasks added by your profile)
Finalize translations
Finished

This way, the things you have to do are "Choose" and "Configure", and the things the system does are "Verify" and "install" and "finalize".

Thoughts? Is this out of scope for the issue?

Should this still be taken up before we get to RC1, so that translators can work on consistent wording?

If so, it should be tagged with Barcelona2015.

It is certainly always better to change strings rather earlier than later.

Here is a crazy idea: Core could come with a better_help module which requires locale and translates the existing help in a way that it contains things properly. Just an idea though.

It seems like if we were going to standardize on anything, we'd standardize on "Distribution." That's what Drupal.org calls these things.

When you download a distribution, it's called a distribution.

However, when you go to the installation screen, it tells you to choose your installation profile, not your distribution, and for that matter when you download just regular Drupal, you have a few profiles to choose from (distros may also?).

Should we tag this for the sprints at Drupalcon Dublin?

This patch was committed to Drupal 8 and Drupal 7 and then re-opened because 'installation profile' was appearing as a step on the installation screen on Drupal 8. That text was changed in #1351352: Distribution installation profiles are no longer able to override the early installer screens to 'install site' and there is nothing more to do here.

Therefor changing to fixed and setting the version bask to Drupal 8.0.x

Thanks all!