Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I think for this one we need a field.yml config file as well?
Comment | File | Size | Author |
---|---|---|---|
#8 | 1798782-9.patch | 2.6 KB | swentel |
#5 | 1798782_field_purge_batch_size_3.patch | 734 bytes | andreiashu |
#2 | 1798782_field_purge_batch_size_1.patch | 710 bytes | andreiashu |
#3 | 1798782_field_purge_batch_size_2.patch | 746 bytes | andreiashu |
#1 | 1798782_field_purge_batch_size_1.patch | 710 bytes | andreiashu |
Comments
Comment #1
andreiashu CreditAttribution: andreiashu commentedComment #2
andreiashu CreditAttribution: andreiashu commentedtagging and back to needs work
edit: not sure how the attached patch for in this comment...
Comment #3
andreiashu CreditAttribution: andreiashu commentedYML file is now called field.settings.yml, updated code as well
Comment #4
yched CreditAttribution: yched commentedWe don't need 'field_' in the name of the new property - 'purge_batch_size' should be enough.
Other than that, this should be ready to fly.
Comment #5
andreiashu CreditAttribution: andreiashu commentedthanks for the review Yves. New patch attached
Comment #6
yched CreditAttribution: yched commentedThanks !
Comment #7
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.
Comment #8
swentel CreditAttribution: swentel commentedSorry te reopen, but the patch missed a couple of field_purge_batch functions which still are hardcoded to 10.
Comment #9
Stalski CreditAttribution: Stalski commentedImprovements are fine
Comment #10
longwaveShould the parameter to field_purge_batch be optional, and default to this config value, rather than having to repeat config()->get() everywhere?
Comment #11
swentel CreditAttribution: swentel commentedSounds plausible, there's no UI for this one anyway and probably never will be either. I can live with both situations, let's wait until a core committer checks the patch.
Comment #12
yched CreditAttribution: yched commentedNope, the hardcoded 10s that remain are intentional. They didn't read from the variable before, ee still want them to be 10 even if someone puts the config value to 1000
Comment #13
swentel CreditAttribution: swentel commentedOh, alright, sorry for the noise :)