Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#17 | drupal_js_cache_files-1798724-17.patch | 2.6 KB | Albert Volkman |
#14 | 13-14-interdiff.txt | 801 bytes | alexpott |
#14 | drupal_js_cache_files-1798724-14.patch | 3.12 KB | alexpott |
#13 | drupal_js_cache_files-1798724-13.patch | 3.13 KB | Albert Volkman |
#13 | interdiff.txt | 525 bytes | Albert Volkman |
Comments
Comment #1
andreiashu CreditAttribution: andreiashu commentedLet's see...
Comment #3
andreiashu CreditAttribution: andreiashu commentedRemoved the double space from drupal_build_js_cache()
Comment #5
andreiashu CreditAttribution: andreiashu commentedNeeded "git config core.filemode false"
Comment #6
andreiashu CreditAttribution: andreiashu commented@alexpott: I tested the '?:' operator and it works as advertised - the following code prints out default:
Comment #7
nod_tagging
Comment #8
alexpottJust realised that actually whilst this does not need an update function to migrate the variable we should be deleting the old variable in an update function so it is not left lying around.
I tested the patch and it works as expected.
Comment #9
andreiashu CreditAttribution: andreiashu commentedAttached new patch with the hook update. Thanks for the review!
Comment #10
alexpottThere's been some discussion around the namespace strategy for state key names on #1790920: Move cron_last, node_cron_last and common_test_cron to state system - the how to has been updated http://drupal.org/node/1787318
So in this instance we probably should change the key to
system.drupal_js_cache_files
Comment #11
Albert Volkman CreditAttribution: Albert Volkman commentedVariable name updated with system namespace.
Comment #13
Albert Volkman CreditAttribution: Albert Volkman commentedForgot to update system_update_N() number.
Comment #14
alexpottPatch to bump system_update_N() number and fixes documentation. Looks good to go. Thanks for the work.
Comment #15
catchCommitted/pushed to 8.x, thanks!
Comment #16
sunWhy didn't we remove the 'drupal_' prefix in the state name?
That prefix was previously used to (poorly) namespace the variable name to a non-existing "drupal" extension. The proper extension namespace is 'system' now, so it should be removed.
Comment #17
Albert Volkman CreditAttribution: Albert Volkman commentedHere's a patch for that.
Comment #18
sunThanks!
Comment #19
catchThanks! Committed/pushed to 8.x.