Random Test failures in Entity translation tests [#1798382]

Failed with a fatal error.

Fatal error: Call to a member function getTranslation() on a non-object in /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/system/lib/Drupal/system/Tests/Entity/EntityTranslationTest.php on line 289
FATAL Drupal\system\Tests\Entity\EntityTranslationTest: test runner returned a non-zero error code (255).

http://qa.drupal.org/pifr/test/348788

I have the test report saved locally in case the link above get's re-tested or otherwise lost...

Comment	File	Size	Author
#5	fixed-zero-can-not-be-set-1798382-5.patch	1.78 KB	Berdir
#5
#5	fixed-zero-can-not-be-set-1798382-5-test-only.patch	1.13 KB	Berdir
#5

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Lars Toomre CreditAttribution: Lars Toomre commented 29 September 2012 at 00:53

Patch in #1798376-1: Remove t() from test asserts in Translation module is also tripping over this issue.

Comment #2

jthorson CreditAttribution: jthorson commented 29 September 2012 at 04:43

Patch in the linked issue from #1 passed on retest. Re-queuing this one too ... if it passes, tag this as 'Random test failure' and bounce to core.

Comment #3

Lars Toomre CreditAttribution: Lars Toomre commented 29 September 2012 at 04:52

Thanks jthorson. There also was another failue to this in #1797410-9: Remove t() from asserts for G-L includes system tests. That result was not overridden.

Comment #4

jthorson CreditAttribution: jthorson commented 29 September 2012 at 05:36

Title:	Test failures in Entity translation tests	» Random Test failures in Entity translation tests
Project:	Drupal.org Testbots	» Drupal core
Version:		» 8.x-dev
Component:	unexplained test failure	» entity system
Priority:	Normal	» Major
Issue tags:		+Random test failure

Passed on retest ... that's two for two on this particular failure.

Reclassifying as intermittent test failure and bouncing to core.

Comment #5

Berdir

German

Switzerland

CreditAttribution: Berdir commented 29 September 2012 at 10:03

Status:

Active

» Needs review

File	Size
fixed-zero-can-not-be-set-1798382-5-test-only.patch	1.13 KB

fixed-zero-can-not-be-set-1798382-5.patch	1.78 KB

Gotcha! ;)

The problem is that entity translation tests sometimes generate a random uid with the value 0. Which is a valid value IMHO. Due to a !empty() instead of an isset(), this value is ignored and so it is never set and NULL is returned for $entity->user_id->value when it's saved to the database. NULL doesn't equal 0 in the database so the EFQ fails and can't load the entity. Kaboom.